Re: [Xen-devel] [PATCH v2] domctl: relax getdomaininfo permissions

2016-08-16 Thread Daniel De Graaf
On 08/11/2016 07:33 AM, Jan Beulich wrote: On 05.08.16 at 13:20, wrote: Daniel, I've only now realized that I forgot to Cc you on this v2. Jan Qemu needs access to this for the domain it controls, both due to it being used by xc_domain_memory_mapping() (which qemu

Re: [Xen-devel] [PATCH v2] domctl: relax getdomaininfo permissions

2016-08-11 Thread Jan Beulich
>>> On 05.08.16 at 13:20, wrote: Daniel, I've only now realized that I forgot to Cc you on this v2. Jan > Qemu needs access to this for the domain it controls, both due to it > being used by xc_domain_memory_mapping() (which qemu calls) and the > explicit use in

Re: [Xen-devel] [PATCH v2] domctl: relax getdomaininfo permissions

2016-08-11 Thread Andrew Cooper
On 08/08/16 07:12, Jan Beulich wrote: On 05.08.16 at 19:07, wrote: >> On 05/08/16 14:54, Jan Beulich wrote: >> On 05.08.16 at 15:10, wrote: On 05/08/16 12:20, Jan Beulich wrote: > I wonder what good the duplication of the

Re: [Xen-devel] [PATCH v2] domctl: relax getdomaininfo permissions

2016-08-08 Thread Jan Beulich
>>> On 05.08.16 at 19:07, wrote: > On 05/08/16 14:54, Jan Beulich wrote: > On 05.08.16 at 15:10, wrote: >>> On 05/08/16 12:20, Jan Beulich wrote: I wonder what good the duplication of the returned domain ID does: I'm tempted to

Re: [Xen-devel] [PATCH v2] domctl: relax getdomaininfo permissions

2016-08-05 Thread Andrew Cooper
On 05/08/16 14:54, Jan Beulich wrote: On 05.08.16 at 15:10, wrote: >> On 05/08/16 12:20, Jan Beulich wrote: >>> I wonder what good the duplication of the returned domain ID does: I'm >>> tempted to remove the one in the command-specific structure. Does >>> anyone

Re: [Xen-devel] [PATCH v2] domctl: relax getdomaininfo permissions

2016-08-05 Thread Jan Beulich
>>> On 05.08.16 at 15:10, wrote: > On 05/08/16 12:20, Jan Beulich wrote: >> I wonder what good the duplication of the returned domain ID does: I'm >> tempted to remove the one in the command-specific structure. Does >> anyone have insight into why it was done that way?

Re: [Xen-devel] [PATCH v2] domctl: relax getdomaininfo permissions

2016-08-05 Thread Andrew Cooper
On 05/08/16 12:20, Jan Beulich wrote: > Qemu needs access to this for the domain it controls, both due to it > being used by xc_domain_memory_mapping() (which qemu calls) and the > explicit use in hw/xenpv/xen_domainbuild.c:xen_domain_poll(). Extend > permissions to that of any "ordinary" domctl:

[Xen-devel] [PATCH v2] domctl: relax getdomaininfo permissions

2016-08-05 Thread Jan Beulich
Qemu needs access to this for the domain it controls, both due to it being used by xc_domain_memory_mapping() (which qemu calls) and the explicit use in hw/xenpv/xen_domainbuild.c:xen_domain_poll(). Extend permissions to that of any "ordinary" domctl: A domain controlling the targeted domain can