Re: [Xen-devel] [PATCH v2] tools: add configure --with-dumpdir=DIR option

2015-05-21 Thread Olaf Hering
On Thu, May 21, Ian Campbell wrote: On Mon, 2015-05-11 at 15:33 +, Olaf Hering wrote: [...] +AC_ARG_WITH([xen-dumpdir], +AS_HELP_STRING([--with-xen-dumpdir=DIR], +[Path to directory for domU crash dumps. [/var/lib/xen/dump]]), Should this say $localstatedir/lib/xen/dump as

Re: [Xen-devel] [PATCH v2] tools: add configure --with-dumpdir=DIR option

2015-05-21 Thread Ian Campbell
On Mon, 2015-05-11 at 15:33 +, Olaf Hering wrote: [...] +AC_ARG_WITH([xen-dumpdir], +AS_HELP_STRING([--with-xen-dumpdir=DIR], +[Path to directory for domU crash dumps. [/var/lib/xen/dump]]), Should this say $localstatedir/lib/xen/dump as below? Other than that: Acked-by:

Re: [Xen-devel] [PATCH v2] tools: add configure --with-dumpdir=DIR option

2015-05-21 Thread Ian Campbell
On Thu, 2015-05-21 at 16:27 +0200, Olaf Hering wrote: On Thu, May 21, Ian Campbell wrote: On Mon, 2015-05-11 at 15:33 +, Olaf Hering wrote: [...] +AC_ARG_WITH([xen-dumpdir], +AS_HELP_STRING([--with-xen-dumpdir=DIR], +[Path to directory for domU crash dumps.

Re: [Xen-devel] [PATCH v2] tools: add configure --with-dumpdir=DIR option

2015-05-11 Thread Olaf Hering
On Fri, May 08, Ian Campbell wrote: On Fri, 2015-05-08 at 08:54 +0200, Olaf Hering wrote: On Thu, May 07, Ian Campbell wrote: On Thu, 2015-05-07 at 10:10 +0200, Olaf Hering wrote: Does anyone actually use the non-FHS compliant current default of /var/xen/dump? Should we consider

[Xen-devel] [PATCH v2] tools: add configure --with-dumpdir=DIR option

2015-05-11 Thread Olaf Hering
The current base directory /var/xen/dump for domU dumps will be patched to /var/lib/xen/dump by most distros to follow FHS. This change does three things: - change the default from /var/xen/dump to /var/lib/xen/dump - provide a configure option to avoid patching the source. - update docs to

Re: [Xen-devel] [PATCH v2] tools: add configure --with-dumpdir=DIR option

2015-05-08 Thread Olaf Hering
On Thu, May 07, Ian Campbell wrote: On Thu, 2015-05-07 at 10:10 +0200, Olaf Hering wrote: On Thu, May 07, Wei Liu wrote: On Wed, May 06, 2015 at 07:08:44AM +, Olaf Hering wrote: The current base directory /var/xen for domU dumps will be patched to /var/lib/xen by most

Re: [Xen-devel] [PATCH v2] tools: add configure --with-dumpdir=DIR option

2015-05-08 Thread Ian Campbell
On Fri, 2015-05-08 at 08:54 +0200, Olaf Hering wrote: On Thu, May 07, Ian Campbell wrote: On Thu, 2015-05-07 at 10:10 +0200, Olaf Hering wrote: On Thu, May 07, Wei Liu wrote: On Wed, May 06, 2015 at 07:08:44AM +, Olaf Hering wrote: The current base directory /var/xen for

Re: [Xen-devel] [PATCH v2] tools: add configure --with-dumpdir=DIR option

2015-05-07 Thread Ian Campbell
On Thu, 2015-05-07 at 10:10 +0200, Olaf Hering wrote: On Thu, May 07, Wei Liu wrote: On Wed, May 06, 2015 at 07:08:44AM +, Olaf Hering wrote: The current base directory /var/xen for domU dumps will be patched to /var/lib/xen by most distros. Provide a configure option to avoid

Re: [Xen-devel] [PATCH v2] tools: add configure --with-dumpdir=DIR option

2015-05-07 Thread Olaf Hering
On Thu, May 07, Wei Liu wrote: On Wed, May 06, 2015 at 07:08:44AM +, Olaf Hering wrote: The current base directory /var/xen for domU dumps will be patched to /var/lib/xen by most distros. Provide a configure option to avoid patching the source. If the option is not specified the

Re: [Xen-devel] [PATCH v2] tools: add configure --with-dumpdir=DIR option

2015-05-07 Thread Wei Liu
On Thu, May 07, 2015 at 10:10:51AM +0200, Olaf Hering wrote: On Thu, May 07, Wei Liu wrote: On Wed, May 06, 2015 at 07:08:44AM +, Olaf Hering wrote: The current base directory /var/xen for domU dumps will be patched to /var/lib/xen by most distros. Provide a configure option to

Re: [Xen-devel] [PATCH v2] tools: add configure --with-dumpdir=DIR option

2015-05-07 Thread Wei Liu
On Wed, May 06, 2015 at 07:08:44AM +, Olaf Hering wrote: The current base directory /var/xen for domU dumps will be patched to /var/lib/xen by most distros. Provide a configure option to avoid patching the source. If the option is not specified the default remains /var/xen/dump.

[Xen-devel] [PATCH v2] tools: add configure --with-dumpdir=DIR option

2015-05-06 Thread Olaf Hering
The current base directory /var/xen for domU dumps will be patched to /var/lib/xen by most distros. Provide a configure option to avoid patching the source. If the option is not specified the default remains /var/xen/dump. Please rerun autogen.sh after applying this patch. Signed-off-by: Olaf