Re: [Xen-devel] [PATCH v2] xen: xen-pciback: remove DRIVER_ATTR() usage

2017-07-19 Thread Juergen Gross
On 19/07/17 17:17, Greg KH wrote: > On Wed, Jul 19, 2017 at 04:51:02PM +0200, Juergen Gross wrote: >> On 19/07/17 16:43, Greg KH wrote: >>> From: Greg Kroah-Hartman >>> >>> It's better to be explicit and use the DRIVER_ATTR_RW() and >>> DRIVER_ATTR_RO() macros when defining a driver's sysfs file.

Re: [Xen-devel] [PATCH v2] xen: xen-pciback: remove DRIVER_ATTR() usage

2017-07-19 Thread Greg KH
On Wed, Jul 19, 2017 at 04:51:02PM +0200, Juergen Gross wrote: > On 19/07/17 16:43, Greg KH wrote: > > From: Greg Kroah-Hartman > > > > It's better to be explicit and use the DRIVER_ATTR_RW() and > > DRIVER_ATTR_RO() macros when defining a driver's sysfs file. > > > > Bonus is this fixes up a ch

Re: [Xen-devel] [PATCH v2] xen: xen-pciback: remove DRIVER_ATTR() usage

2017-07-19 Thread Juergen Gross
On 19/07/17 16:43, Greg KH wrote: > From: Greg Kroah-Hartman > > It's better to be explicit and use the DRIVER_ATTR_RW() and > DRIVER_ATTR_RO() macros when defining a driver's sysfs file. > > Bonus is this fixes up a checkpatch.pl warning. > > This is part of a series to drop DRIVER_ATTR() from

[Xen-devel] [PATCH v2] xen: xen-pciback: remove DRIVER_ATTR() usage

2017-07-19 Thread Greg KH
From: Greg Kroah-Hartman It's better to be explicit and use the DRIVER_ATTR_RW() and DRIVER_ATTR_RO() macros when defining a driver's sysfs file. Bonus is this fixes up a checkpatch.pl warning. This is part of a series to drop DRIVER_ATTR() from the tree entirely. Cc: Boris Ostrovsky Cc: Juer