Re: [Xen-devel] [PATCH v2 0/2] Remove PAGE_SIZE from public headers

2016-10-21 Thread Stefano Stabellini
On Fri, 21 Oct 2016, Wei Liu wrote: > On Thu, Oct 20, 2016 at 01:38:35PM -0700, Stefano Stabellini wrote: > > On Thu, 20 Oct 2016, Andrew Cooper wrote: > > > On 20/10/16 21:04, Stefano Stabellini wrote: > > > > On Thu, 20 Oct 2016, Andrew Cooper wrote: > > > >> On 20/10/16 20:09, Stefano Stabellini

Re: [Xen-devel] [PATCH v2 0/2] Remove PAGE_SIZE from public headers

2016-10-21 Thread Stefano Stabellini
On Fri, 21 Oct 2016, Wei Liu wrote: > On Thu, Oct 20, 2016 at 09:05:26PM +0100, Andrew Cooper wrote: > > On 20/10/16 21:04, Stefano Stabellini wrote: > > > On Thu, 20 Oct 2016, Andrew Cooper wrote: > > >> On 20/10/16 20:09, Stefano Stabellini wrote: > > >>> On Thu, 20 Oct 2016, Juergen Gross wrote:

Re: [Xen-devel] [PATCH v2 0/2] Remove PAGE_SIZE from public headers

2016-10-21 Thread Wei Liu
On Thu, Oct 20, 2016 at 01:38:35PM -0700, Stefano Stabellini wrote: > On Thu, 20 Oct 2016, Andrew Cooper wrote: > > On 20/10/16 21:04, Stefano Stabellini wrote: > > > On Thu, 20 Oct 2016, Andrew Cooper wrote: > > >> On 20/10/16 20:09, Stefano Stabellini wrote: > > >>> On Thu, 20 Oct 2016, Juergen G

Re: [Xen-devel] [PATCH v2 0/2] Remove PAGE_SIZE from public headers

2016-10-21 Thread Wei Liu
On Thu, Oct 20, 2016 at 09:05:26PM +0100, Andrew Cooper wrote: > On 20/10/16 21:04, Stefano Stabellini wrote: > > On Thu, 20 Oct 2016, Andrew Cooper wrote: > >> On 20/10/16 20:09, Stefano Stabellini wrote: > >>> On Thu, 20 Oct 2016, Juergen Gross wrote: > On 19/10/16 21:21, stef...@aporeto.com

Re: [Xen-devel] [PATCH v2 0/2] Remove PAGE_SIZE from public headers

2016-10-20 Thread Stefano Stabellini
On Thu, 20 Oct 2016, Andrew Cooper wrote: > On 20/10/16 21:04, Stefano Stabellini wrote: > > On Thu, 20 Oct 2016, Andrew Cooper wrote: > >> On 20/10/16 20:09, Stefano Stabellini wrote: > >>> On Thu, 20 Oct 2016, Juergen Gross wrote: > On 19/10/16 21:21, stef...@aporeto.com wrote: > > Refer

Re: [Xen-devel] [PATCH v2 0/2] Remove PAGE_SIZE from public headers

2016-10-20 Thread Andrew Cooper
On 20/10/16 21:04, Stefano Stabellini wrote: > On Thu, 20 Oct 2016, Andrew Cooper wrote: >> On 20/10/16 20:09, Stefano Stabellini wrote: >>> On Thu, 20 Oct 2016, Juergen Gross wrote: On 19/10/16 21:21, stef...@aporeto.com wrote: > Reference to PAGE_SIZE slipped in to two public header file

Re: [Xen-devel] [PATCH v2 0/2] Remove PAGE_SIZE from public headers

2016-10-20 Thread Stefano Stabellini
On Thu, 20 Oct 2016, Andrew Cooper wrote: > On 20/10/16 20:09, Stefano Stabellini wrote: > > On Thu, 20 Oct 2016, Juergen Gross wrote: > >> On 19/10/16 21:21, stef...@aporeto.com wrote: > >>> Reference to PAGE_SIZE slipped in to two public header files. QEMU build > >>> on > >>> ARM64 is broken by

Re: [Xen-devel] [PATCH v2 0/2] Remove PAGE_SIZE from public headers

2016-10-20 Thread Andrew Cooper
On 20/10/16 20:09, Stefano Stabellini wrote: > On Thu, 20 Oct 2016, Juergen Gross wrote: >> On 19/10/16 21:21, stef...@aporeto.com wrote: >>> Reference to PAGE_SIZE slipped in to two public header files. QEMU build on >>> ARM64 is broken by this. PAGE_SIZE should not be used because it could >>> be

Re: [Xen-devel] [PATCH v2 0/2] Remove PAGE_SIZE from public headers

2016-10-20 Thread Stefano Stabellini
On Thu, 20 Oct 2016, Juergen Gross wrote: > On 19/10/16 21:21, stef...@aporeto.com wrote: > > Reference to PAGE_SIZE slipped in to two public header files. QEMU build on > > ARM64 is broken by this. PAGE_SIZE should not be used because it could > > be undefined or it could be defined differently on

Re: [Xen-devel] [PATCH v2 0/2] Remove PAGE_SIZE from public headers

2016-10-19 Thread Juergen Gross
On 19/10/16 21:21, stef...@aporeto.com wrote: > Reference to PAGE_SIZE slipped in to two public header files. QEMU build on > ARM64 is broken by this. PAGE_SIZE should not be used because it could > be undefined or it could be defined differently on different operating > systems. > > Stefano Stabe

[Xen-devel] [PATCH v2 0/2] Remove PAGE_SIZE from public headers

2016-10-19 Thread stefano
Reference to PAGE_SIZE slipped in to two public header files. QEMU build on ARM64 is broken by this. PAGE_SIZE should not be used because it could be undefined or it could be defined differently on different operating systems. Stefano Stabellini (2): usbif.h: replace PAGE_SIZE with USBIF_RIN