Re: [Xen-devel] [PATCH v2 05/12] x86emul: use eflags definitions in x86-defns.h

2017-01-31 Thread Jan Beulich
>>> On 31.01.17 at 15:55, wrote: > On Tue, Jan 31, 2017 at 05:56:38AM -0700, Jan Beulich wrote: >> With this taken care of and the #include style matching whatever >> is chosen as the final model in the earlier patch, >> Reviewed-by: Jan Beulich >>

Re: [Xen-devel] [PATCH v2 05/12] x86emul: use eflags definitions in x86-defns.h

2017-01-31 Thread Wei Liu
On Tue, Jan 31, 2017 at 05:56:38AM -0700, Jan Beulich wrote: > >>> On 31.01.17 at 12:08, wrote: > > @@ -5016,20 +5004,20 @@ x86_emulate( > > > > /* > > * SYSCALL (unlike most instructions) evaluates its singlestep > > action > > - * based on the

Re: [Xen-devel] [PATCH v2 05/12] x86emul: use eflags definitions in x86-defns.h

2017-01-31 Thread Jan Beulich
>>> On 31.01.17 at 12:08, wrote: > @@ -5016,20 +5004,20 @@ x86_emulate( > > /* > * SYSCALL (unlike most instructions) evaluates its singlestep action > - * based on the resulting EFLG_TF, not the starting EFLG_TF. > + * based on the

[Xen-devel] [PATCH v2 05/12] x86emul: use eflags definitions in x86-defns.h

2017-01-31 Thread Wei Liu
Basically this patch does 's/EFLG_/X86_EFLAGS_/g' and with indentation fixed up. And remove the duplicates in x86_emualte.c. This in turn requires userspace test harness to include x86-defns.h. Also remove a few duplicates in userspace harness program. No functional change. Signed-off-by: Wei