Re: [Xen-devel] [PATCH v2 08/23] x86: add multiboot2 protocol support

2015-08-18 Thread Jan Beulich
>>> On 18.08.15 at 14:00, wrote: > On Tue, Aug 18, 2015 at 02:12:58AM -0600, Jan Beulich wrote: >> >>> On 20.07.15 at 16:29, wrote: >> > @@ -119,10 +213,11 @@ __start: >> > >> > /* Save the Multiboot info struct (after relocation) for later >> > use. */ >> > mov $sym_phys(c

Re: [Xen-devel] [PATCH v2 08/23] x86: add multiboot2 protocol support

2015-08-18 Thread Daniel Kiper
On Tue, Aug 18, 2015 at 02:12:58AM -0600, Jan Beulich wrote: > >>> On 20.07.15 at 16:29, wrote: [...] > > @@ -119,10 +213,11 @@ __start: > > > > /* Save the Multiboot info struct (after relocation) for later > > use. */ > > mov $sym_phys(cpu0_stack)+1024,%esp > > +

Re: [Xen-devel] [PATCH v2 08/23] x86: add multiboot2 protocol support

2015-08-18 Thread Jan Beulich
>>> On 20.07.15 at 16:29, wrote: > v2 - not fixed yet: >- dynamic dependency generation for xen/arch/x86/boot/reloc.S; > this requires more work; I am not sure that it pays because > potential patch requires more changes than addition of just > multiboot2.h to Makefile > (s

Re: [Xen-devel] [PATCH v2 08/23] x86: add multiboot2 protocol support

2015-08-14 Thread Andrew Cooper
On 14/08/15 11:03, Jan Beulich wrote: On 13.08.15 at 21:22, wrote: On Mon, Aug 10, 2015 at 03:17:48PM -0400, Konrad Rzeszutek Wilk wrote: On Mon, Jul 20, 2015 at 04:29:03PM +0200, Daniel Kiper wrote: @@ -34,6 +57,42 @@ multiboot1_header_start: /*** MULTIBOOT1 HEADER / .l

Re: [Xen-devel] [PATCH v2 08/23] x86: add multiboot2 protocol support

2015-08-14 Thread Jan Beulich
>>> On 13.08.15 at 21:22, wrote: > On Mon, Aug 10, 2015 at 03:17:48PM -0400, Konrad Rzeszutek Wilk wrote: >> On Mon, Jul 20, 2015 at 04:29:03PM +0200, Daniel Kiper wrote: >> > @@ -34,6 +57,42 @@ multiboot1_header_start: /*** MULTIBOOT1 HEADER >> > / >> > .long -(MULTIBOOT_HEA

Re: [Xen-devel] [PATCH v2 08/23] x86: add multiboot2 protocol support

2015-08-13 Thread Daniel Kiper
On Mon, Aug 10, 2015 at 03:17:48PM -0400, Konrad Rzeszutek Wilk wrote: > On Mon, Jul 20, 2015 at 04:29:03PM +0200, Daniel Kiper wrote: > > Add multiboot2 protocol support. Alter min memory limit handling as we > > now may not find it from either multiboot (v1) or multiboot2. > > > > This way we are

Re: [Xen-devel] [PATCH v2 08/23] x86: add multiboot2 protocol support

2015-08-10 Thread Konrad Rzeszutek Wilk
On Mon, Jul 20, 2015 at 04:29:03PM +0200, Daniel Kiper wrote: > Add multiboot2 protocol support. Alter min memory limit handling as we > now may not find it from either multiboot (v1) or multiboot2. > > This way we are laying the foundation for EFI + GRUB2 + Xen development. > > Signed-off-by: Da

[Xen-devel] [PATCH v2 08/23] x86: add multiboot2 protocol support

2015-07-20 Thread Daniel Kiper
Add multiboot2 protocol support. Alter min memory limit handling as we now may not find it from either multiboot (v1) or multiboot2. This way we are laying the foundation for EFI + GRUB2 + Xen development. Signed-off-by: Daniel Kiper Reviewed-by: Andrew Cooper --- v2 - suggestions/fixes: - g