Re: [Xen-devel] [PATCH v2 09/12] x86/altp2m: add remaining support routines.

On 06/29/2015 06:03 AM, Andrew Cooper wrote: > On 26/06/15 17:30, Ed White wrote: >> On 06/24/2015 11:19 AM, Andrew Cooper wrote: >>> On 24/06/15 18:47, Ed White wrote: >> This looks like some hoop jumping around the assertions in >> domain_pause() and vcpu_pause(). >> >> We should

Re: [Xen-devel] [PATCH v2 09/12] x86/altp2m: add remaining support routines.

On 26/06/15 17:30, Ed White wrote: > On 06/24/2015 11:19 AM, Andrew Cooper wrote: >> On 24/06/15 18:47, Ed White wrote: > This looks like some hoop jumping around the assertions in > domain_pause() and vcpu_pause(). > > We should probably have some new helpers where the domain needs

Re: [Xen-devel] [PATCH v2 09/12] x86/altp2m: add remaining support routines.

On 06/24/2015 11:19 AM, Andrew Cooper wrote: > On 24/06/15 18:47, Ed White wrote: This looks like some hoop jumping around the assertions in domain_pause() and vcpu_pause(). We should probably have some new helpers where the domain needs to be paused, possibly while in cont

Re: [Xen-devel] [PATCH v2 09/12] x86/altp2m: add remaining support routines.

On 06/25/2015 06:40 AM, Razvan Cojocaru wrote: > On 06/25/2015 03:44 PM, Lengyel, Tamas wrote: >> On Wed, Jun 24, 2015 at 2:06 PM, Ed White > > wrote: >> On 06/24/2015 09:15 AM, Lengyel, Tamas wrote: >> >> +bool_t p2m_set_altp2m_mem_access(struct domain *d,

Re: [Xen-devel] [PATCH v2 09/12] x86/altp2m: add remaining support routines.

On 06/25/2015 03:45 PM, Lengyel, Tamas wrote: > On Thu, Jun 25, 2015 at 4:46 PM, Ed White wrote: > >> On 06/25/2015 11:23 AM, Lengyel, Tamas wrote: >>> On Thu, Jun 25, 2015 at 12:48 PM, Ed White >> wrote: >>> On 06/25/2015 06:40 AM, Razvan Cojocaru wrote: > On 06/25/2015 03:44 PM, Lengy

Re: [Xen-devel] [PATCH v2 09/12] x86/altp2m: add remaining support routines.

On Thu, Jun 25, 2015 at 4:46 PM, Ed White wrote: > On 06/25/2015 11:23 AM, Lengyel, Tamas wrote: > > On Thu, Jun 25, 2015 at 12:48 PM, Ed White > wrote: > > > >> On 06/25/2015 06:40 AM, Razvan Cojocaru wrote: > >>> On 06/25/2015 03:44 PM, Lengyel, Tamas wrote: > On Wed, Jun 24, 2015 at 2:06

Re: [Xen-devel] [PATCH v2 09/12] x86/altp2m: add remaining support routines.

On Thu, Jun 25, 2015 at 4:27 PM, Ed White wrote: > On 06/25/2015 10:42 AM, Lengyel, Tamas wrote: > > On Thu, Jun 25, 2015 at 12:31 PM, Ed White > wrote: > > > >> On 06/24/2015 07:44 PM, Lengyel, Tamas wrote: > +if ( altp2m_active ) > +{ > +if ( altp2mhvm_hap_nested

Re: [Xen-devel] [PATCH v2 09/12] x86/altp2m: add remaining support routines.

On 06/25/2015 11:23 AM, Lengyel, Tamas wrote: > On Thu, Jun 25, 2015 at 12:48 PM, Ed White wrote: > >> On 06/25/2015 06:40 AM, Razvan Cojocaru wrote: >>> On 06/25/2015 03:44 PM, Lengyel, Tamas wrote: On Wed, Jun 24, 2015 at 2:06 PM, Ed White >>> > wrote:

Re: [Xen-devel] [PATCH v2 09/12] x86/altp2m: add remaining support routines.

On 06/25/2015 10:42 AM, Lengyel, Tamas wrote: > On Thu, Jun 25, 2015 at 12:31 PM, Ed White wrote: > >> On 06/24/2015 07:44 PM, Lengyel, Tamas wrote: +if ( altp2m_active ) +{ +if ( altp2mhvm_hap_nested_page_fault(v, gpa, gla, npfec, &p2m) >> == 1 ) +

Re: [Xen-devel] [PATCH v2 09/12] x86/altp2m: add remaining support routines.

On Thu, Jun 25, 2015 at 12:48 PM, Ed White wrote: > On 06/25/2015 06:40 AM, Razvan Cojocaru wrote: > > On 06/25/2015 03:44 PM, Lengyel, Tamas wrote: > >> On Wed, Jun 24, 2015 at 2:06 PM, Ed White >> > wrote: > >> On 06/24/2015 09:15 AM, Lengyel, Tamas wrote:

Re: [Xen-devel] [PATCH v2 09/12] x86/altp2m: add remaining support routines.

On 06/25/2015 07:48 PM, Ed White wrote: > On 06/25/2015 06:40 AM, Razvan Cojocaru wrote: >> On 06/25/2015 03:44 PM, Lengyel, Tamas wrote: >>> On Wed, Jun 24, 2015 at 2:06 PM, Ed White >> > wrote: >>> On 06/24/2015 09:15 AM, Lengyel, Tamas wrote: >>> >> +bool

Re: [Xen-devel] [PATCH v2 09/12] x86/altp2m: add remaining support routines.

On Thu, Jun 25, 2015 at 12:31 PM, Ed White wrote: > On 06/24/2015 07:44 PM, Lengyel, Tamas wrote: > >> +if ( altp2m_active ) > >> +{ > >> +if ( altp2mhvm_hap_nested_page_fault(v, gpa, gla, npfec, &p2m) > == > >> 1 ) > >> +{ > >> +/* entry was lazily copied from

Re: [Xen-devel] [PATCH v2 09/12] x86/altp2m: add remaining support routines.

On 06/25/2015 06:40 AM, Razvan Cojocaru wrote: > On 06/25/2015 03:44 PM, Lengyel, Tamas wrote: >> On Wed, Jun 24, 2015 at 2:06 PM, Ed White > > wrote: >> On 06/24/2015 09:15 AM, Lengyel, Tamas wrote: >> >> +bool_t p2m_set_altp2m_mem_access(struct domain *d,

Re: [Xen-devel] [PATCH v2 09/12] x86/altp2m: add remaining support routines.

On 06/24/2015 07:44 PM, Lengyel, Tamas wrote: >> +if ( altp2m_active ) >> +{ >> +if ( altp2mhvm_hap_nested_page_fault(v, gpa, gla, npfec, &p2m) == >> 1 ) >> +{ >> +/* entry was lazily copied from host -- retry */ >> > > So I'm not fully following this logic here

Re: [Xen-devel] [PATCH v2 09/12] x86/altp2m: add remaining support routines.

On 06/25/2015 01:52 AM, Ian Campbell wrote: > On Wed, 2015-06-24 at 11:06 -0700, Ed White wrote: >> I think we should vote on this. > > In general we vote on things only when there has been a failure to reach > consensus. Unless there has been some prior discussion around this issue > which isn't

Re: [Xen-devel] [PATCH v2 09/12] x86/altp2m: add remaining support routines.

On 06/25/2015 03:44 PM, Lengyel, Tamas wrote: > On Wed, Jun 24, 2015 at 2:06 PM, Ed White > wrote: > On 06/24/2015 09:15 AM, Lengyel, Tamas wrote: > >> +bool_t p2m_set_altp2m_mem_access(struct domain *d, uint16_t idx, > >> +

Re: [Xen-devel] [PATCH v2 09/12] x86/altp2m: add remaining support routines.

On Wed, Jun 24, 2015 at 2:06 PM, Ed White wrote: > On 06/24/2015 09:15 AM, Lengyel, Tamas wrote: > >> +bool_t p2m_set_altp2m_mem_access(struct domain *d, uint16_t idx, > >> + unsigned long pfn, xenmem_access_t > >> access) > >> +{ > >> > > > > This function IMHO sh

Re: [Xen-devel] [PATCH v2 09/12] x86/altp2m: add remaining support routines.

On Wed, 2015-06-24 at 11:06 -0700, Ed White wrote: > I think we should vote on this. In general we vote on things only when there has been a failure to reach consensus. Unless there has been some prior discussion around this issue which isn't referenced from the bits of the thread I've looked at t

Re: [Xen-devel] [PATCH v2 09/12] x86/altp2m: add remaining support routines.

On Mon, Jun 22, 2015 at 2:56 PM, Ed White wrote: > Add the remaining routines required to support enabling the alternate > p2m functionality. > > Signed-off-by: Ed White > --- > xen/arch/x86/hvm/hvm.c | 60 +- > xen/arch/x86/mm/hap/Makefile| 1 + > xen/arch/x86/mm/ha

Re: [Xen-devel] [PATCH v2 09/12] x86/altp2m: add remaining support routines.

On 24/06/15 18:47, Ed White wrote: >> > This looks like some hoop jumping around the assertions in >> > domain_pause() and vcpu_pause(). >> > >> > We should probably have some new helpers where the domain needs to be >> > paused, possibly while in context. The current domain/vcpu_pause() are >> >

Re: [Xen-devel] [PATCH v2 09/12] x86/altp2m: add remaining support routines.

On 06/24/2015 09:15 AM, Lengyel, Tamas wrote: >> +bool_t p2m_set_altp2m_mem_access(struct domain *d, uint16_t idx, >> + unsigned long pfn, xenmem_access_t >> access) >> +{ >> > > This function IMHO should be merged with p2m_set_mem_access and should be > triggerable

Re: [Xen-devel] [PATCH v2 09/12] x86/altp2m: add remaining support routines.

On 06/24/2015 06:46 AM, Andrew Cooper wrote: > On 22/06/15 19:56, Ed White wrote: >> Add the remaining routines required to support enabling the alternate >> p2m functionality. >> >> Signed-off-by: Ed White >> --- >> xen/arch/x86/hvm/hvm.c | 60 +- >> xen/arch/x86/mm/hap/Makefil

Re: [Xen-devel] [PATCH v2 09/12] x86/altp2m: add remaining support routines.

On Mon, Jun 22, 2015 at 2:56 PM, Ed White wrote: > Add the remaining routines required to support enabling the alternate > p2m functionality. > > Signed-off-by: Ed White > --- > xen/arch/x86/hvm/hvm.c | 60 +- > xen/arch/x86/mm/hap/Makefile| 1 + > xen/arch/x86/mm/ha

Re: [Xen-devel] [PATCH v2 09/12] x86/altp2m: add remaining support routines.

On 22/06/15 19:56, Ed White wrote: > Add the remaining routines required to support enabling the alternate > p2m functionality. > > Signed-off-by: Ed White > --- > xen/arch/x86/hvm/hvm.c | 60 +- > xen/arch/x86/mm/hap/Makefile| 1 + > xen/arch/x86/mm/hap/altp2m_hap.c

Re: [Xen-devel] [PATCH v2 09/12] x86/altp2m: add remaining support routines.

On Tue, Jun 23, 2015 at 2:52 PM, Ed White wrote: > On 06/23/2015 11:15 AM, Lengyel, Tamas wrote: > > On Mon, Jun 22, 2015 at 2:56 PM, Ed White > wrote: > > > >> Add the remaining routines required to support enabling the alternate > >> p2m functionality. > >> > >> Signed-off-by: Ed White > >> -

Re: [Xen-devel] [PATCH v2 09/12] x86/altp2m: add remaining support routines.

On 06/23/2015 11:15 AM, Lengyel, Tamas wrote: > On Mon, Jun 22, 2015 at 2:56 PM, Ed White wrote: > >> Add the remaining routines required to support enabling the alternate >> p2m functionality. >> >> Signed-off-by: Ed White >> --- >> xen/arch/x86/hvm/hvm.c | 60 +- >> xen/arch

Re: [Xen-devel] [PATCH v2 09/12] x86/altp2m: add remaining support routines.

On Mon, Jun 22, 2015 at 2:56 PM, Ed White wrote: > Add the remaining routines required to support enabling the alternate > p2m functionality. > > Signed-off-by: Ed White > --- > xen/arch/x86/hvm/hvm.c | 60 +- > xen/arch/x86/mm/hap/Makefile| 1 + > xen/arch/x86/mm/ha

[Xen-devel] [PATCH v2 09/12] x86/altp2m: add remaining support routines.

Add the remaining routines required to support enabling the alternate p2m functionality. Signed-off-by: Ed White --- xen/arch/x86/hvm/hvm.c | 60 +- xen/arch/x86/mm/hap/Makefile| 1 + xen/arch/x86/mm/hap/altp2m_hap.c| 103 + xen/arch/x86/mm/p2m-ept.c