Re: [Xen-devel] [PATCH v2 1/2] kexec: use hypercall_create_continuation to protect KEXEC ops

2017-04-19 Thread Eric DeVolder
On 04/19/2017 06:48 AM, Andrew Cooper wrote: On 19/04/17 12:00, Daniel Kiper wrote: On Tue, Apr 18, 2017 at 04:48:06AM -0600, Jan Beulich wrote: On 17.04.17 at 21:09, wrote: --- a/xen/common/kexec.c +++ b/xen/common/kexec.c @@ -50,9 +50,10 @@ static cpumask_t

Re: [Xen-devel] [PATCH v2 1/2] kexec: use hypercall_create_continuation to protect KEXEC ops

2017-04-19 Thread Daniel Kiper
On Wed, Apr 19, 2017 at 12:48:56PM +0100, Andrew Cooper wrote: > On 19/04/17 12:00, Daniel Kiper wrote: > > On Tue, Apr 18, 2017 at 04:48:06AM -0600, Jan Beulich wrote: > > On 17.04.17 at 21:09, wrote: > >>> --- a/xen/common/kexec.c > >>> +++ b/xen/common/kexec.c >

Re: [Xen-devel] [PATCH v2 1/2] kexec: use hypercall_create_continuation to protect KEXEC ops

2017-04-19 Thread Andrew Cooper
On 19/04/17 12:00, Daniel Kiper wrote: > On Tue, Apr 18, 2017 at 04:48:06AM -0600, Jan Beulich wrote: > On 17.04.17 at 21:09, wrote: >>> --- a/xen/common/kexec.c >>> +++ b/xen/common/kexec.c >>> @@ -50,9 +50,10 @@ static cpumask_t crash_saved_cpus; >>> >>> static

Re: [Xen-devel] [PATCH v2 1/2] kexec: use hypercall_create_continuation to protect KEXEC ops

2017-04-19 Thread Daniel Kiper
On Tue, Apr 18, 2017 at 04:48:06AM -0600, Jan Beulich wrote: > >>> On 17.04.17 at 21:09, wrote: > > --- a/xen/common/kexec.c > > +++ b/xen/common/kexec.c > > @@ -50,9 +50,10 @@ static cpumask_t crash_saved_cpus; > > > > static struct kexec_image

Re: [Xen-devel] [PATCH v2 1/2] kexec: use hypercall_create_continuation to protect KEXEC ops

2017-04-18 Thread Jan Beulich
>>> On 17.04.17 at 21:09, wrote: > --- a/xen/common/kexec.c > +++ b/xen/common/kexec.c > @@ -50,9 +50,10 @@ static cpumask_t crash_saved_cpus; > > static struct kexec_image *kexec_image[KEXEC_IMAGE_NR]; > > -#define KEXEC_FLAG_DEFAULT_POS (KEXEC_IMAGE_NR + 0) >

[Xen-devel] [PATCH v2 1/2] kexec: use hypercall_create_continuation to protect KEXEC ops

2017-04-17 Thread Eric DeVolder
When we concurrently try to unload and load crash images we eventually get: Xen call trace: [] machine_kexec_add_page+0x3a0/0x3fa [] machine_kexec_load+0xdb/0x107 [] kexec.c#kexec_load_slot+0x11/0x42 [] kexec.c#kexec_load+0x119/0x150 [] kexec.c#do_kexec_op_internal+0xab/0xcf