Re: [Xen-devel] [PATCH v2 1/2] mini-os: partially revert "remove using start_info ..."

2016-08-29 Thread Samuel Thibault
Juergen Gross, on Mon 29 Aug 2016 16:18:26 +0200, wrote: > Commit e33452c4f5547ed14defe6382b3b53664ac5bd8a ("remove using > start_info in architecture independent code") removed the start_info > variable completely. grub stubdom needs the start_info structure. > > Readd the start_info structure,

Re: [Xen-devel] [PATCH v2 1/2] mini-os: partially revert "remove using start_info ..."

2016-08-29 Thread Samuel Thibault
Samuel Thibault, on Mon 29 Aug 2016 22:49:07 +0200, wrote: > Juergen Gross, on Mon 29 Aug 2016 16:18:26 +0200, wrote: > > +union start_info_union > > +{ > > +start_info_t start_info; > > +char padding[512]; > > +}; > > Why defining a union? 512 is actually not enough for start_info_t.

Re: [Xen-devel] [PATCH v2 1/2] mini-os: partially revert "remove using start_info ..."

2016-08-29 Thread Samuel Thibault
Hello, Juergen Gross, on Mon 29 Aug 2016 16:18:26 +0200, wrote: > +union start_info_union > +{ > +start_info_t start_info; > +char padding[512]; > +}; Why defining a union? 512 is actually not enough for start_info_t. Samuel ___ Xen-devel

[Xen-devel] [PATCH v2 1/2] mini-os: partially revert "remove using start_info ..."

2016-08-29 Thread Juergen Gross
Commit e33452c4f5547ed14defe6382b3b53664ac5bd8a ("remove using start_info in architecture independent code") removed the start_info variable completely. grub stubdom needs the start_info structure. Readd the start_info structure, but make it dependent on CONFIG_PARAVIRT. Signed-off-by: Juergen