Re: [Xen-devel] [PATCH v2 1/3] libxl: add PV display device driver interface

2017-06-21 Thread Oleksandr Grytsov
On Tue, Jun 20, 2017 at 4:54 PM, Wei Liu wrote: > On Thu, May 25, 2017 at 03:17:29PM +0300, Oleksandr Grytsov wrote: >> From: Oleksandr Grytsov >> Hi Wei, Thank you for your reply. > I'm sorry, patch like this is impossible to review because: 1. there is > no commit message 2. it is huge. I w

Re: [Xen-devel] [PATCH v2 1/3] libxl: add PV display device driver interface

2017-06-20 Thread Wei Liu
On Thu, May 25, 2017 at 03:17:29PM +0300, Oleksandr Grytsov wrote: > From: Oleksandr Grytsov > I'm sorry, patch like this is impossible to review because: 1. there is no commit message 2. it is huge. I can see it is adding a lot of hooks to the device handling framework. Please explain why they

[Xen-devel] [PATCH v2 1/3] libxl: add PV display device driver interface

2017-05-25 Thread Oleksandr Grytsov
From: Oleksandr Grytsov Signed-off-by: Oleksandr Grytsov --- tools/libxl/Makefile | 2 +- tools/libxl/libxl.h | 21 ++ tools/libxl/libxl_create.c | 3 + tools/libxl/libxl_device.c | 178 - tools/libxl/libxl_internal.h