Re: [Xen-devel] [PATCH v2 1/4] xen/init: Annotate all command line parameter infrastructure as const

2016-06-23 Thread Andrew Cooper
On 23/06/16 17:00, Jan Beulich wrote: On 21.06.16 at 18:59, wrote: >> --- a/xen/include/xen/init.h >> +++ b/xen/include/xen/init.h >> @@ -86,10 +86,11 @@ struct kernel_param { >> void *var; >> }; >> >> -extern struct kernel_param __setup_start, __setup_end; >> +extern const struct ker

Re: [Xen-devel] [PATCH v2 1/4] xen/init: Annotate all command line parameter infrastructure as const

2016-06-23 Thread Jan Beulich
>>> On 21.06.16 at 18:59, wrote: > --- a/xen/include/xen/init.h > +++ b/xen/include/xen/init.h > @@ -86,10 +86,11 @@ struct kernel_param { > void *var; > }; > > -extern struct kernel_param __setup_start, __setup_end; > +extern const struct kernel_param __setup_start[], __setup_end[]; > >

Re: [Xen-devel] [PATCH v2 1/4] xen/init: Annotate all command line parameter infrastructure as const

2016-06-23 Thread Julien Grall
Hi Andrew, On 21/06/16 17:59, Andrew Cooper wrote: There is no reason for any of it to be modified. Additionally, link .init.setup beside the other constant .init data. While editing this area, correct the types used in the extern declarations for __setup_start and __setup_end to match the typ

Re: [Xen-devel] [PATCH v2 1/4] xen/init: Annotate all command line parameter infrastructure as const

2016-06-21 Thread Jan Beulich
>>> On 21.06.16 at 18:59, wrote: > There is no reason for any of it to be modified. Additionally, link > .init.setup beside the other constant .init data. > > While editing this area, correct the types used in the extern > declarations for __setup_start and __setup_end to match the types the > l

[Xen-devel] [PATCH v2 1/4] xen/init: Annotate all command line parameter infrastructure as const

2016-06-21 Thread Andrew Cooper
There is no reason for any of it to be modified. Additionally, link .init.setup beside the other constant .init data. While editing this area, correct the types used in the extern declarations for __setup_start and __setup_end to match the types the linker actually produces. No functional change