Re: [Xen-devel] [PATCH v2 15/52] xen/arch/x86/nmi.c: let custom parameter parsing routines return errno

2017-08-14 Thread Juergen Gross
On 14/08/17 15:31, Jan Beulich wrote: On 14.08.17 at 09:08, wrote: >> /* opt_watchdog_timeout: Number of seconds to wait before panic. */ >> static unsigned int opt_watchdog_timeout = 5; >> -static void parse_watchdog_timeout(char * s) >> +static int

Re: [Xen-devel] [PATCH v2 15/52] xen/arch/x86/nmi.c: let custom parameter parsing routines return errno

2017-08-14 Thread Jan Beulich
>>> On 14.08.17 at 09:08, wrote: > /* opt_watchdog_timeout: Number of seconds to wait before panic. */ > static unsigned int opt_watchdog_timeout = 5; > -static void parse_watchdog_timeout(char * s) > +static int parse_watchdog_timeout(char * s) Please also remove the stray

[Xen-devel] [PATCH v2 15/52] xen/arch/x86/nmi.c: let custom parameter parsing routines return errno

2017-08-14 Thread Juergen Gross
Modify the custom parameter parsing routines in: xen/arch/x86/nmi.c to indicate whether the parameter value was parsed successfully. Cc: Jan Beulich Cc: Andrew Cooper Signed-off-by: Juergen Gross Acked-by: Wei Liu