Re: [Xen-devel] [PATCH v2 16/16] x86emul: don't assume a memory operand

2016-09-30 Thread Jan Beulich
>>> On 29.09.16 at 23:12, wrote: > On 28/09/16 09:19, Jan Beulich wrote: >> @@ -2216,7 +2217,7 @@ x86_decode( >> } >> } >> >> -if ( override_seg != -1 && ea.type == OP_MEM ) >> +if ( override_seg != x86_seg_none ) > > I don't see why the "ea.type == OP_MEM" should be dropp

Re: [Xen-devel] [PATCH v2 16/16] x86emul: don't assume a memory operand

2016-09-29 Thread Andrew Cooper
On 28/09/16 09:19, Jan Beulich wrote: > Especially for x86_insn_operand_ea() to return dependable segment > information even when the caller didn't consider applicability, we > shouldn't have ea.type start out as OP_MEM. Make it OP_NONE instead, > and set it to OP_MEM when we actually encounter mem

[Xen-devel] [PATCH v2 16/16] x86emul: don't assume a memory operand

2016-09-28 Thread Jan Beulich
Especially for x86_insn_operand_ea() to return dependable segment information even when the caller didn't consider applicability, we shouldn't have ea.type start out as OP_MEM. Make it OP_NONE instead, and set it to OP_MEM when we actually encounter memory like operands. This requires to eliminate