Re: [Xen-devel] [PATCH v2 2/2] kexec: remove spinlock now that all KEXEC hypercall ops are protected at the top-level

2017-04-19 Thread Eric DeVolder
On 04/19/2017 08:37 AM, Jan Beulich wrote: On 19.04.17 at 14:13, wrote: On Wed, Apr 19, 2017 at 05:20:50AM -0600, Jan Beulich wrote: On 19.04.17 at 12:56, wrote: On Tue, Apr 18, 2017 at 04:49:48AM -0600, Jan Beulich wrote: On 17.04.17 at

Re: [Xen-devel] [PATCH v2 2/2] kexec: remove spinlock now that all KEXEC hypercall ops are protected at the top-level

2017-04-19 Thread Jan Beulich
>>> On 19.04.17 at 14:13, wrote: > On Wed, Apr 19, 2017 at 05:20:50AM -0600, Jan Beulich wrote: >> >>> On 19.04.17 at 12:56, wrote: >> > On Tue, Apr 18, 2017 at 04:49:48AM -0600, Jan Beulich wrote: >> >> >>> On 17.04.17 at 21:09,

Re: [Xen-devel] [PATCH v2 2/2] kexec: remove spinlock now that all KEXEC hypercall ops are protected at the top-level

2017-04-19 Thread Daniel Kiper
On Wed, Apr 19, 2017 at 05:20:50AM -0600, Jan Beulich wrote: > >>> On 19.04.17 at 12:56, wrote: > > On Tue, Apr 18, 2017 at 04:49:48AM -0600, Jan Beulich wrote: > >> >>> On 17.04.17 at 21:09, wrote: > >> > The spinlock in kexec_swap_images() was

Re: [Xen-devel] [PATCH v2 2/2] kexec: remove spinlock now that all KEXEC hypercall ops are protected at the top-level

2017-04-19 Thread Andrew Cooper
On 19/04/17 12:20, Jan Beulich wrote: On 19.04.17 at 12:56, wrote: >> On Tue, Apr 18, 2017 at 04:49:48AM -0600, Jan Beulich wrote: >> On 17.04.17 at 21:09, wrote: The spinlock in kexec_swap_images() was removed as this

Re: [Xen-devel] [PATCH v2 2/2] kexec: remove spinlock now that all KEXEC hypercall ops are protected at the top-level

2017-04-19 Thread Jan Beulich
>>> On 19.04.17 at 12:56, wrote: > On Tue, Apr 18, 2017 at 04:49:48AM -0600, Jan Beulich wrote: >> >>> On 17.04.17 at 21:09, wrote: >> > The spinlock in kexec_swap_images() was removed as >> > this function is only reachable on the kexec

Re: [Xen-devel] [PATCH v2 2/2] kexec: remove spinlock now that all KEXEC hypercall ops are protected at the top-level

2017-04-19 Thread Daniel Kiper
On Tue, Apr 18, 2017 at 04:49:48AM -0600, Jan Beulich wrote: > >>> On 17.04.17 at 21:09, wrote: > > The spinlock in kexec_swap_images() was removed as > > this function is only reachable on the kexec hypercall, which is > > now protected at the top-level in

Re: [Xen-devel] [PATCH v2 2/2] kexec: remove spinlock now that all KEXEC hypercall ops are protected at the top-level

2017-04-18 Thread Jan Beulich
>>> On 17.04.17 at 21:09, wrote: > The spinlock in kexec_swap_images() was removed as > this function is only reachable on the kexec hypercall, which is > now protected at the top-level in do_kexec_op_internal(), > thus the local spinlock is no longer necessary. But

[Xen-devel] [PATCH v2 2/2] kexec: remove spinlock now that all KEXEC hypercall ops are protected at the top-level

2017-04-17 Thread Eric DeVolder
The spinlock in kexec_swap_images() was removed as this function is only reachable on the kexec hypercall, which is now protected at the top-level in do_kexec_op_internal(), thus the local spinlock is no longer necessary. Signed-off-by: Eric DeVolder Reviewed-by: