Re: [Xen-devel] [PATCH v2 2/2] x86/altp2m: allow specifying external-only use-case

2016-08-16 Thread Daniel De Graaf
On 08/11/2016 10:51 AM, Jan Beulich wrote: On 11.08.16 at 16:37, wrote: On Aug 11, 2016 06:02, "Jan Beulich" wrote: On 10.08.16 at 17:00, wrote: @@ -5238,18 +5238,19 @@ static int do_altp2m_op( goto out;

Re: [Xen-devel] [PATCH v2 2/2] x86/altp2m: allow specifying external-only use-case

2016-08-12 Thread Wei Liu
On Fri, Aug 12, 2016 at 08:51:14AM -0600, Tamas K Lengyel wrote: > On Aug 12, 2016 05:24, "Julien Grall" wrote: > > > > Hello Tamas, > > > > > > On 10/08/2016 17:00, Tamas K Lengyel wrote: > >> > >> diff --git a/tools/libxl/libxl_types.idl b/tools/libxl/libxl_types.idl > >>

Re: [Xen-devel] [PATCH v2 2/2] x86/altp2m: allow specifying external-only use-case

2016-08-12 Thread Tamas K Lengyel
On Aug 12, 2016 05:24, "Julien Grall" wrote: > > Hello Tamas, > > > On 10/08/2016 17:00, Tamas K Lengyel wrote: >> >> diff --git a/tools/libxl/libxl_types.idl b/tools/libxl/libxl_types.idl >> index ef614be..97948fd 100644 >> --- a/tools/libxl/libxl_types.idl >> +++

Re: [Xen-devel] [PATCH v2 2/2] x86/altp2m: allow specifying external-only use-case

2016-08-12 Thread Julien Grall
Hello Tamas, On 10/08/2016 17:00, Tamas K Lengyel wrote: diff --git a/tools/libxl/libxl_types.idl b/tools/libxl/libxl_types.idl index ef614be..97948fd 100644 --- a/tools/libxl/libxl_types.idl +++ b/tools/libxl/libxl_types.idl @@ -439,6 +439,13 @@ libxl_rdm_reserve = Struct("rdm_reserve", [

Re: [Xen-devel] [PATCH v2 2/2] x86/altp2m: allow specifying external-only use-case

2016-08-11 Thread Wei Liu
On Thu, Aug 11, 2016 at 11:50:44AM -0600, Tamas K Lengyel wrote: > On Thu, Aug 11, 2016 at 11:17 AM, Wei Liu wrote: > > On Wed, Aug 10, 2016 at 09:00:15AM -0600, Tamas K Lengyel wrote: > >> Currently setting altp2mhvm=1 in the domain configuration allows access to > >> the >

Re: [Xen-devel] [PATCH v2 2/2] x86/altp2m: allow specifying external-only use-case

2016-08-11 Thread Tamas K Lengyel
On Thu, Aug 11, 2016 at 11:17 AM, Wei Liu wrote: > On Wed, Aug 10, 2016 at 09:00:15AM -0600, Tamas K Lengyel wrote: >> Currently setting altp2mhvm=1 in the domain configuration allows access to >> the >> altp2m interface for both in-guest and external privileged tools. This

Re: [Xen-devel] [PATCH v2 2/2] x86/altp2m: allow specifying external-only use-case

2016-08-11 Thread Wei Liu
On Wed, Aug 10, 2016 at 09:00:15AM -0600, Tamas K Lengyel wrote: > Currently setting altp2mhvm=1 in the domain configuration allows access to the > altp2m interface for both in-guest and external privileged tools. This poses > a problem for use-cases where only external access should be allowed,

Re: [Xen-devel] [PATCH v2 2/2] x86/altp2m: allow specifying external-only use-case

2016-08-11 Thread Jan Beulich
>>> On 11.08.16 at 16:37, wrote: > On Aug 11, 2016 06:02, "Jan Beulich" wrote: >> >> >>> On 10.08.16 at 17:00, wrote: >> > @@ -5238,18 +5238,19 @@ static int do_altp2m_op( >> > goto out; >> > } >> > >> > -

Re: [Xen-devel] [PATCH v2 2/2] x86/altp2m: allow specifying external-only use-case

2016-08-11 Thread Tamas K Lengyel
On Aug 11, 2016 06:02, "Jan Beulich" wrote: > > >>> On 10.08.16 at 17:00, wrote: > > @@ -5238,18 +5238,19 @@ static int do_altp2m_op( > > goto out; > > } > > > > -if ( (rc = xsm_hvm_altp2mhvm_op(XSM_TARGET, d)) ) > > +if (

Re: [Xen-devel] [PATCH v2 2/2] x86/altp2m: allow specifying external-only use-case

2016-08-11 Thread Jan Beulich
>>> On 10.08.16 at 17:00, wrote: > @@ -5238,18 +5238,19 @@ static int do_altp2m_op( > goto out; > } > > -if ( (rc = xsm_hvm_altp2mhvm_op(XSM_TARGET, d)) ) > +if ( !d->arch.hvm_domain.params[HVM_PARAM_ALTP2M] ) > +{ > +rc = -EINVAL; >

[Xen-devel] [PATCH v2 2/2] x86/altp2m: allow specifying external-only use-case

2016-08-10 Thread Tamas K Lengyel
Currently setting altp2mhvm=1 in the domain configuration allows access to the altp2m interface for both in-guest and external privileged tools. This poses a problem for use-cases where only external access should be allowed, requiring the user to compile Xen with XSM enabled to be able to