[Xen-devel] [PATCH v2 2/3] util/grub.d/20_linux_xen.in: Add arm64 support

2015-07-13 Thread fu . wei
From: Fu Wei This patch adds the support of boot command on arm64 for XEN: xen_hypervisor xen_module Signed-off-by: Fu Wei --- util/grub.d/20_linux_xen.in | 14 +++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/util/grub.d/20_linux_xen.in b/util/grub.d/20_li

Re: [Xen-devel] [PATCH v2 2/3] util/grub.d/20_linux_xen.in: Add arm64 support

2015-07-13 Thread Andrei Borzenkov
В Mon, 13 Jul 2015 16:53:59 +0800 fu@linaro.org пишет: > From: Fu Wei > > This patch adds the support of boot command on arm64 for XEN: > xen_hypervisor > xen_module > > Signed-off-by: Fu Wei > --- > util/grub.d/20_linux_xen.in | 14 +++--- > 1 file changed, 11 insertions(

Re: [Xen-devel] [PATCH v2 2/3] util/grub.d/20_linux_xen.in: Add arm64 support

2015-07-14 Thread Ian Campbell
On Tue, 2015-07-14 at 06:53 +0300, Andrei Borzenkov wrote: > > +if [ "x$machine" != xaarch64 ]; then > > + multiboot_cmd="multiboot" > > + module_cmd="module" > > +else > > + multiboot_cmd="xen_hypervisor" > > + module_cmd="xen_module" > > +fi > > + > > Strictly speaking, this is boot-time

Re: [Xen-devel] [PATCH v2 2/3] util/grub.d/20_linux_xen.in: Add arm64 support

2015-07-14 Thread Fu Wei
Hi Andrei, Great thanks for your review. So Are you suggesting this: (1) in util/grub.d/20_linux_xen.in, we only use xen_hypervisor/xen_module. (2) in xen_boot.c, we only register command xen_hypervisor/xen_module. (3) in grub-core/loader/i386/xen.c, we *add* --- cmd_xen_hypervisort

Re: [Xen-devel] [PATCH v2 2/3] util/grub.d/20_linux_xen.in: Add arm64 support

2015-07-14 Thread Konrad Rzeszutek Wilk
On Tue, Jul 14, 2015 at 10:41:28AM +0100, Ian Campbell wrote: > On Tue, 2015-07-14 at 06:53 +0300, Andrei Borzenkov wrote: > > > +if [ "x$machine" != xaarch64 ]; then > > > + multiboot_cmd="multiboot" > > > + module_cmd="module" And we should use the grub-file --is-multiboot2 to figure out if the

Re: [Xen-devel] [PATCH v2 2/3] util/grub.d/20_linux_xen.in: Add arm64 support

2015-07-15 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 14.07.2015 15:09, Fu Wei wrote: > Hi Andrei, > > Great thanks for your review. > > So Are you suggesting this: > (1) in util/grub.d/20_linux_xen.in, we only use xen_hypervisor/xen_module. > (2) in xen_boot.c, we only register command xen_hypervisor/xen_module. > (3) in grub-core/loader/i386/xe