Re: [Xen-devel] [PATCH v2 2/6] x86/mm/pat: Add pat_disable() interface

2016-03-23 Thread Toshi Kani
On Wed, 2016-03-23 at 09:51 +0100, Borislav Petkov wrote: > On Tue, Mar 22, 2016 at 03:40:45PM -0600, Toshi Kani wrote: > > Will change to "Prevent the OS from initializing the PAT MSR". > > > > I wanted to clarify that "disable" does not mean to disable PAT MSR. > > How do you "disable PAT MSR"

Re: [Xen-devel] [PATCH v2 2/6] x86/mm/pat: Add pat_disable() interface

2016-03-23 Thread Borislav Petkov
On Tue, Mar 22, 2016 at 03:40:45PM -0600, Toshi Kani wrote: > Will change to "Prevent the OS from initializing the PAT MSR". > > I wanted to clarify that "disable" does not mean to disable PAT MSR. How do you "disable PAT MSR" ? I think you're overdocumenting this. pat_disable() is as clear as

Re: [Xen-devel] [PATCH v2 2/6] x86/mm/pat: Add pat_disable() interface

2016-03-22 Thread Toshi Kani
On Tue, 2016-03-22 at 17:59 +0100, Borislav Petkov wrote: > On Wed, Mar 16, 2016 at 06:46:55PM -0600, Toshi Kani wrote: > > In preparation to fix a regression caused by 'commit 9cd25aac1f44 > > ("x86/mm/pat: Emulate PAT when it is disabled")', PAT needs to > > provide an interface that disables

Re: [Xen-devel] [PATCH v2 2/6] x86/mm/pat: Add pat_disable() interface

2016-03-22 Thread Borislav Petkov
On Wed, Mar 16, 2016 at 06:46:55PM -0600, Toshi Kani wrote: > In preparation to fix a regression caused by 'commit 9cd25aac1f44 > ("x86/mm/pat: Emulate PAT when it is disabled")', PAT needs to > provide an interface that disables the OS to initialize PAT MSR. prevents the

[Xen-devel] [PATCH v2 2/6] x86/mm/pat: Add pat_disable() interface

2016-03-19 Thread Toshi Kani
In preparation to fix a regression caused by 'commit 9cd25aac1f44 ("x86/mm/pat: Emulate PAT when it is disabled")', PAT needs to provide an interface that disables the OS to initialize PAT MSR. PAT MSR initialization must be done on all CPUs with the specific sequence of operations defined in