Re: [Xen-devel] [PATCH v2 39/52] xen: check parameter validity when parsing command line

2017-08-15 Thread Wei Liu
On Tue, Aug 15, 2017 at 02:54:07PM +0200, Juergen Gross wrote: > On 14/08/17 14:46, Jan Beulich wrote: > On 14.08.17 at 09:08, wrote: > >> --- a/xen/common/kernel.c > >> +++ b/xen/common/kernel.c > >> optval[-1] = '\0'; > >> +break; >

Re: [Xen-devel] [PATCH v2 39/52] xen: check parameter validity when parsing command line

2017-08-15 Thread Jan Beulich
>>> On 15.08.17 at 14:54, wrote: > On 14/08/17 14:46, Jan Beulich wrote: > On 14.08.17 at 09:08, wrote: >>> --- a/xen/common/kernel.c >>> +++ b/xen/common/kernel.c >>> optval[-1] = '\0'; >>> +break; >> >> Why?

Re: [Xen-devel] [PATCH v2 39/52] xen: check parameter validity when parsing command line

2017-08-15 Thread Juergen Gross
On 14/08/17 14:46, Jan Beulich wrote: On 14.08.17 at 09:08, wrote: >> --- a/xen/common/kernel.c >> +++ b/xen/common/kernel.c >> optval[-1] = '\0'; >> +break; > > Why? Applies to further break-s you add: At least in the past we > had

Re: [Xen-devel] [PATCH v2 39/52] xen: check parameter validity when parsing command line

2017-08-14 Thread Jan Beulich
>>> On 14.08.17 at 15:31, wrote: > On 14/08/17 14:46, Jan Beulich wrote: > On 14.08.17 at 09:08, wrote: >>> @@ -97,8 +102,9 @@ static void __init _cmdline_parse(const char *cmdline) >>> !strncmp(param->name, opt, q + 1 - opt) ) >>>

Re: [Xen-devel] [PATCH v2 39/52] xen: check parameter validity when parsing command line

2017-08-14 Thread Juergen Gross
On 14/08/17 14:46, Jan Beulich wrote: On 14.08.17 at 09:08, wrote: >> --- a/xen/common/kernel.c >> +++ b/xen/common/kernel.c >> @@ -23,9 +23,11 @@ enum system_state system_state = SYS_STATE_early_boot; >> xen_commandline_t saved_cmdline; >> static const char __initconst

Re: [Xen-devel] [PATCH v2 39/52] xen: check parameter validity when parsing command line

2017-08-14 Thread Jan Beulich
>>> On 14.08.17 at 09:08, wrote: > --- a/xen/common/kernel.c > +++ b/xen/common/kernel.c > @@ -23,9 +23,11 @@ enum system_state system_state = SYS_STATE_early_boot; > xen_commandline_t saved_cmdline; > static const char __initconst opt_builtin_cmdline[] = CONFIG_CMDLINE; > >

[Xen-devel] [PATCH v2 39/52] xen: check parameter validity when parsing command line

2017-08-14 Thread Juergen Gross
Where possible check validity of parameters in _cmdline_parse() and issue a warning message in case of an error detected. Cc: Andrew Cooper Cc: George Dunlap Cc: Ian Jackson Cc: Jan Beulich