Re: [Xen-devel] [PATCH v2 4/6] iommu: Remove dependency on __LINE__ for release builds

2017-03-15 Thread Tian, Kevin
> From: Ross Lagerwall [mailto:ross.lagerw...@citrix.com] > Sent: Thursday, March 9, 2017 1:47 AM > > When using LivePatch, use of __LINE__ can generate spurious changes in > functions due to embedded line numbers. For release builds with LivePatch > enabled, remove the use of these line numbers

Re: [Xen-devel] [PATCH v2 4/6] iommu: Remove dependency on __LINE__ for release builds

2017-03-09 Thread Jan Beulich
>>> On 08.03.17 at 18:46, wrote: When seeing the title I wondered by I didn't get Cc-ed. Perhaps the prefix would better have been VT-d: ? > --- a/xen/drivers/passthrough/vtd/dmar.h > +++ b/xen/drivers/passthrough/vtd/dmar.h > @@ -108,6 +108,19 @@ struct

[Xen-devel] [PATCH v2 4/6] iommu: Remove dependency on __LINE__ for release builds

2017-03-08 Thread Ross Lagerwall
When using LivePatch, use of __LINE__ can generate spurious changes in functions due to embedded line numbers. For release builds with LivePatch enabled, remove the use of these line numbers in IOMMU_WAIT_OP() and print the current text address instead. Signed-off-by: Ross Lagerwall