Re: [Xen-devel] [PATCH v3 01/19] xen: dump vNUMA information with debug key "u"

2015-01-15 Thread Andrew Cooper
On 15/01/15 08:14, Jan Beulich wrote: On 14.01.15 at 18:25, wrote: >> I modify my code and here are some output examples: >> >> (XEN) Domain 1 (total: 768064): >> (XEN) Node 0: 768064 >> (XEN) 2 vnodes, 20 vcpus, guest physical layout: >> (XEN) 0: pnode 0 vcpus 0-9 >> (XEN

Re: [Xen-devel] [PATCH v3 01/19] xen: dump vNUMA information with debug key "u"

2015-01-15 Thread Jan Beulich
>>> On 14.01.15 at 18:25, wrote: > I modify my code and here are some output examples: > > (XEN) Domain 1 (total: 768064): > (XEN) Node 0: 768064 > (XEN) 2 vnodes, 20 vcpus, guest physical layout: > (XEN) 0: pnode 0 vcpus 0-9 > (XEN) - 5dc00

Re: [Xen-devel] [PATCH v3 01/19] xen: dump vNUMA information with debug key "u"

2015-01-14 Thread Wei Liu
On Wed, Jan 14, 2015 at 02:49:17PM +, Jan Beulich wrote: > >>> On 14.01.15 at 12:45, wrote: > > On 14/01/15 11:24, Jan Beulich wrote: > > On 14.01.15 at 12:06, wrote: > >>> May I suggest the following sylistic changes: > >>> > >>> 2 vnodes, 20 vcpus: > >>> 1: pnode 0, vcpus {1-9} > >>>

Re: [Xen-devel] [PATCH v3 01/19] xen: dump vNUMA information with debug key "u"

2015-01-14 Thread Jan Beulich
>>> On 14.01.15 at 13:02, wrote: > On Wed, Jan 14, 2015 at 11:45:25AM +, Andrew Cooper wrote: >> On 14/01/15 11:24, Jan Beulich wrote: >> On 14.01.15 at 12:06, wrote: >> >> May I suggest the following sylistic changes: >> >> >> >> 2 vnodes, 20 vcpus: >> >> 1: pnode 0, vcpus {1-9} >> >>

Re: [Xen-devel] [PATCH v3 01/19] xen: dump vNUMA information with debug key "u"

2015-01-14 Thread Jan Beulich
>>> On 14.01.15 at 12:45, wrote: > On 14/01/15 11:24, Jan Beulich wrote: > On 14.01.15 at 12:06, wrote: >>> May I suggest the following sylistic changes: >>> >>> 2 vnodes, 20 vcpus: >>> 1: pnode 0, vcpus {1-9} >>> - 5dc0 >>> 2: pnode 1, vcpus {10-20} >>>

Re: [Xen-devel] [PATCH v3 01/19] xen: dump vNUMA information with debug key "u"

2015-01-14 Thread Wei Liu
On Wed, Jan 14, 2015 at 11:45:25AM +, Andrew Cooper wrote: > On 14/01/15 11:24, Jan Beulich wrote: > On 14.01.15 at 12:06, wrote: > >> May I suggest the following sylistic changes: > >> > >> 2 vnodes, 20 vcpus: > >> 1: pnode 0, vcpus {1-9} > >> - 5dc0 >

Re: [Xen-devel] [PATCH v3 01/19] xen: dump vNUMA information with debug key "u"

2015-01-14 Thread Andrew Cooper
On 14/01/15 11:24, Jan Beulich wrote: On 14.01.15 at 12:06, wrote: >> May I suggest the following sylistic changes: >> >> 2 vnodes, 20 vcpus: >> 1: pnode 0, vcpus {1-9} >> - 5dc0 >> 2: pnode 1, vcpus {10-20} >> 5dc0 - bb00 >>

Re: [Xen-devel] [PATCH v3 01/19] xen: dump vNUMA information with debug key "u"

2015-01-14 Thread Jan Beulich
>>> On 14.01.15 at 12:06, wrote: > May I suggest the following sylistic changes: > > 2 vnodes, 20 vcpus: > 1: pnode 0, vcpus {1-9} > - 5dc0 > 2: pnode 1, vcpus {10-20} > 5dc0 - bb00 > 0001 - 00010080 > > Yo

Re: [Xen-devel] [PATCH v3 01/19] xen: dump vNUMA information with debug key "u"

2015-01-14 Thread Andrew Cooper
On 13/01/15 20:51, Wei Liu wrote: > >>> + >>> +vnuma = d->vnuma; >>> +printk(" %u vnodes, %u vcpus:\n", vnuma->nr_vnodes, >>> d->max_vcpus); >>> +for ( i = 0; i < vnuma->nr_vnodes; i++ ) >>> +{ >>> +err = snprintf(keyhandler_scratch, 12, "%3u", >>> +

Re: [Xen-devel] [PATCH v3 01/19] xen: dump vNUMA information with debug key "u"

2015-01-13 Thread Wei Liu
On Tue, Jan 13, 2015 at 07:21:47PM +, Andrew Cooper wrote: > On 13/01/15 12:11, Wei Liu wrote: > > @@ -408,6 +413,49 @@ static void dump_numa(unsigned char key) > > > > for_each_online_node ( i ) > > printk("Node %u: %u\n", i, page_num_node[i]); > > + > > +if

Re: [Xen-devel] [PATCH v3 01/19] xen: dump vNUMA information with debug key "u"

2015-01-13 Thread Andrew Cooper
On 13/01/15 12:11, Wei Liu wrote: > @@ -408,6 +413,49 @@ static void dump_numa(unsigned char key) > > for_each_online_node ( i ) > printk("Node %u: %u\n", i, page_num_node[i]); > + > +if ( !d->vnuma ) > +continue; Nit - extraneous whitespace. >

Re: [Xen-devel] [PATCH v3 01/19] xen: dump vNUMA information with debug key "u"

2015-01-13 Thread Wei Liu
On Tue, Jan 13, 2015 at 04:38:33PM +, Jan Beulich wrote: > >>> On 13.01.15 at 13:11, wrote: > > @@ -408,6 +413,49 @@ static void dump_numa(unsigned char key) > > > > for_each_online_node ( i ) > > printk("Node %u: %u\n", i, page_num_node[i]); > > + > > +if (

Re: [Xen-devel] [PATCH v3 01/19] xen: dump vNUMA information with debug key "u"

2015-01-13 Thread Jan Beulich
>>> On 13.01.15 at 13:11, wrote: > @@ -408,6 +413,49 @@ static void dump_numa(unsigned char key) > > for_each_online_node ( i ) > printk("Node %u: %u\n", i, page_num_node[i]); > + > +if ( !d->vnuma ) > +continue; > + > +vnuma = d->vnuma;

[Xen-devel] [PATCH v3 01/19] xen: dump vNUMA information with debug key "u"

2015-01-13 Thread Wei Liu
Signed-off-by: Elena Ufimsteva Signed-off-by: Wei Liu Cc: Jan Beulich --- Changes in v3: 1. Constify struct vnuma_info. 2. Don't print amount of ram of a vmemrange. 3. Process softirqs when dumping information. 4. Fix format string. Changes in v2: 1. Use unsigned int for loop vars. 2. Use strlc