Re: [Xen-devel] [PATCH v3 04/15] x86: refactor psr: Encapsulate 'cbm_len' and 'cbm_max'

2016-11-30 Thread Yi Sun
On 16-11-30 02:42:20, Jan Beulich wrote: > >>> On 30.11.16 at 10:08, wrote: > > On 16-11-29 02:43:24, Jan Beulich wrote: > >> >>> On 29.11.16 at 05:38, wrote: > >> > To make codes be better reviewable, I propose below three suggestions: > >> >

Re: [Xen-devel] [PATCH v3 04/15] x86: refactor psr: Encapsulate 'cbm_len' and 'cbm_max'

2016-11-30 Thread Jan Beulich
>>> On 30.11.16 at 10:08, wrote: > On 16-11-29 02:43:24, Jan Beulich wrote: >> >>> On 29.11.16 at 05:38, wrote: >> > To make codes be better reviewable, I propose below three suggestions: >> > 1) I write a design document about refactor to make

Re: [Xen-devel] [PATCH v3 04/15] x86: refactor psr: Encapsulate 'cbm_len' and 'cbm_max'

2016-11-30 Thread Yi Sun
On 16-11-29 02:43:24, Jan Beulich wrote: > >>> On 29.11.16 at 05:38, wrote: > > To make codes be better reviewable, I propose below three suggestions: > > 1) I write a design document about refactor to make you more easily > > understand the ideas. > > This is

Re: [Xen-devel] [PATCH v3 04/15] x86: refactor psr: Encapsulate 'cbm_len' and 'cbm_max'

2016-11-29 Thread Jan Beulich
>>> On 29.11.16 at 05:38, wrote: > To make codes be better reviewable, I propose below three suggestions: > 1) I write a design document about refactor to make you more easily > understand the ideas. This is appreciated, but I don't think it's strictly necessary.

Re: [Xen-devel] [PATCH v3 04/15] x86: refactor psr: Encapsulate 'cbm_len' and 'cbm_max'

2016-11-28 Thread Yi Sun
On 16-11-25 09:57:31, Jan Beulich wrote: > >>> On 25.11.16 at 17:27, wrote: > On 25.10.16 at 05:40, wrote: > >> 'cbm_len' and 'cbm_max' are CAT/CDP specific feature HW info. > >> So encapsulate them into 'struct psr_cat_hw_info'. If new > >>

Re: [Xen-devel] [PATCH v3 04/15] x86: refactor psr: Encapsulate 'cbm_len' and 'cbm_max'

2016-11-25 Thread Jan Beulich
>>> On 25.11.16 at 17:27, wrote: On 25.10.16 at 05:40, wrote: >> 'cbm_len' and 'cbm_max' are CAT/CDP specific feature HW info. >> So encapsulate them into 'struct psr_cat_hw_info'. If new >> feature is supported, we can define other structure to

Re: [Xen-devel] [PATCH v3 04/15] x86: refactor psr: Encapsulate 'cbm_len' and 'cbm_max'

2016-11-25 Thread Jan Beulich
>>> On 25.10.16 at 05:40, wrote: > 'cbm_len' and 'cbm_max' are CAT/CDP specific feature HW info. > So encapsulate them into 'struct psr_cat_hw_info'. If new > feature is supported, we can define other structure to save > its HW info. Part of my problem following you

[Xen-devel] [PATCH v3 04/15] x86: refactor psr: Encapsulate 'cbm_len' and 'cbm_max'

2016-10-24 Thread Yi Sun
'cbm_len' and 'cbm_max' are CAT/CDP specific feature HW info. So encapsulate them into 'struct psr_cat_hw_info'. If new feature is supported, we can define other structure to save its HW info. Signed-off-by: Yi Sun --- xen/arch/x86/psr.c | 33