Re: [Xen-devel] [PATCH v3 1/2] kexec: use hypercall_create_continuation to protect KEXEC ops

2017-04-20 Thread Jan Beulich
>>> On 20.04.17 at 12:42, wrote: > On Thu, Apr 20, 2017 at 03:34:21AM -0600, Jan Beulich wrote: >> >>> On 19.04.17 at 19:16, wrote: >> > On Wed, Apr 19, 2017 at 10:19:44AM -0600, Jan Beulich wrote: >> >> >>> On 19.04.17 at 17:54, wrote: >> >> > On Wed, Apr 19, 2017 at 10:47:15AM -0500, Eric DeVo

Re: [Xen-devel] [PATCH v3 1/2] kexec: use hypercall_create_continuation to protect KEXEC ops

2017-04-20 Thread Daniel Kiper
On Thu, Apr 20, 2017 at 03:34:21AM -0600, Jan Beulich wrote: > >>> On 19.04.17 at 19:16, wrote: > > On Wed, Apr 19, 2017 at 10:19:44AM -0600, Jan Beulich wrote: > >> >>> On 19.04.17 at 17:54, wrote: > >> > On Wed, Apr 19, 2017 at 10:47:15AM -0500, Eric DeVolder wrote: > >> >> @@ -1193,6 +1194,9 @

Re: [Xen-devel] [PATCH v3 1/2] kexec: use hypercall_create_continuation to protect KEXEC ops

2017-04-20 Thread Jan Beulich
>>> On 19.04.17 at 19:16, wrote: > On Wed, Apr 19, 2017 at 10:19:44AM -0600, Jan Beulich wrote: >> >>> On 19.04.17 at 17:54, wrote: >> > On Wed, Apr 19, 2017 at 10:47:15AM -0500, Eric DeVolder wrote: >> >> @@ -1193,6 +1194,9 @@ static int do_kexec_op_internal(unsigned long op, >> >> if ( ret

Re: [Xen-devel] [PATCH v3 1/2] kexec: use hypercall_create_continuation to protect KEXEC ops

2017-04-19 Thread Daniel Kiper
On Wed, Apr 19, 2017 at 10:19:44AM -0600, Jan Beulich wrote: > >>> On 19.04.17 at 17:54, wrote: > > On Wed, Apr 19, 2017 at 10:47:15AM -0500, Eric DeVolder wrote: > >> @@ -1193,6 +1194,9 @@ static int do_kexec_op_internal(unsigned long op, > >> if ( ret ) > >> return ret; > >> > >> +

Re: [Xen-devel] [PATCH v3 1/2] kexec: use hypercall_create_continuation to protect KEXEC ops

2017-04-19 Thread Jan Beulich
>>> On 19.04.17 at 17:54, wrote: > On Wed, Apr 19, 2017 at 10:47:15AM -0500, Eric DeVolder wrote: >> @@ -1193,6 +1194,9 @@ static int do_kexec_op_internal(unsigned long op, >> if ( ret ) >> return ret; >> >> +if ( test_and_set_bit(KEXEC_FLAG_IN_HYPERCALL, &kexec_flags) ) >> +

Re: [Xen-devel] [PATCH v3 1/2] kexec: use hypercall_create_continuation to protect KEXEC ops

2017-04-19 Thread Daniel Kiper
On Wed, Apr 19, 2017 at 10:47:15AM -0500, Eric DeVolder wrote: > When we concurrently try to unload and load crash > images we eventually get: > > Xen call trace: > [] machine_kexec_add_page+0x3a0/0x3fa > [] machine_kexec_load+0xdb/0x107 > [] kexec.c#kexec_load_slot+0x11/0x42 > []

[Xen-devel] [PATCH v3 1/2] kexec: use hypercall_create_continuation to protect KEXEC ops

2017-04-19 Thread Eric DeVolder
When we concurrently try to unload and load crash images we eventually get: Xen call trace: [] machine_kexec_add_page+0x3a0/0x3fa [] machine_kexec_load+0xdb/0x107 [] kexec.c#kexec_load_slot+0x11/0x42 [] kexec.c#kexec_load+0x119/0x150 [] kexec.c#do_kexec_op_internal+0xab/0xcf