Re: [Xen-devel] [PATCH v3 1/2] libxl: Implement the handler to handle unrecoverable AER errors

2017-09-21 Thread Ian Jackson
Venu Busireddy writes ("Re: [PATCH v3 1/2] libxl: Implement the handler to handle unrecoverable AER errors"): > On 2017-08-08 15:33:01 +0100, Wei Liu wrote: > > I think a bigger question is whether you agree with Ian's comments > > regarding API design and whether you have more questions? > > Ian

Re: [Xen-devel] [PATCH v3 1/2] libxl: Implement the handler to handle unrecoverable AER errors

2017-08-08 Thread Wei Liu
On Tue, Aug 08, 2017 at 09:51:36AM -0500, Venu Busireddy wrote: > I will implement all your above suggestions in v4. > > > I think a bigger question is whether you agree with Ian's comments > > regarding API design and whether you have more questions? > > Ian suggested that I document the use of

Re: [Xen-devel] [PATCH v3 1/2] libxl: Implement the handler to handle unrecoverable AER errors

2017-08-08 Thread Venu Busireddy
On 2017-08-08 15:33:01 +0100, Wei Liu wrote: > On Mon, Aug 07, 2017 at 06:54:56PM -0500, Venu Busireddy wrote: > > Implement the callback function to handle unrecoverable AER errors, and > > also the public APIs that can be used to register/unregister the handler. > > When an AER error occurs, the

Re: [Xen-devel] [PATCH v3 1/2] libxl: Implement the handler to handle unrecoverable AER errors

2017-08-08 Thread Wei Liu
On Tue, Aug 08, 2017 at 03:33:01PM +0100, Wei Liu wrote: > > + > > +int libxl_reg_aer_events_handler(libxl_ctx *ctx, > > + uint32_t domid, > > + libxl_aer_watch **aer_ws_out) > > Afaict libxl_aer_watch is an opaque type to external ca

Re: [Xen-devel] [PATCH v3 1/2] libxl: Implement the handler to handle unrecoverable AER errors

2017-08-08 Thread Wei Liu
On Mon, Aug 07, 2017 at 06:54:56PM -0500, Venu Busireddy wrote: > Implement the callback function to handle unrecoverable AER errors, and > also the public APIs that can be used to register/unregister the handler. > When an AER error occurs, the handler will forcibly remove the erring > PCIe device

[Xen-devel] [PATCH v3 1/2] libxl: Implement the handler to handle unrecoverable AER errors

2017-08-07 Thread Venu Busireddy
Implement the callback function to handle unrecoverable AER errors, and also the public APIs that can be used to register/unregister the handler. When an AER error occurs, the handler will forcibly remove the erring PCIe device from the guest. Signed-off-by: Venu Busireddy --- tools/libxl/libxl.

[Xen-devel] [PATCH v3 1/2] libxl: Implement the handler to handle unrecoverable AER errors

2017-08-07 Thread Venu Busireddy
Implement the callback function to handle unrecoverable AER errors, and also the public APIs that can be used to register/unregister the handler. When an AER error occurs, the handler will forcibly remove the erring PCIe device from the guest. Signed-off-by: Venu Busireddy --- tools/libxl/libxl.

[Xen-devel] [PATCH v3 1/2] libxl: Implement the handler to handle unrecoverable AER errors

2017-08-07 Thread Venu Busireddy
Implement the callback function to handle unrecoverable AER errors, and also the public APIs that can be used to register/unregister the handler. When an AER error occurs, the handler will forcibly remove the erring PCIe device from the guest. Signed-off-by: Venu Busireddy --- tools/libxl/libxl.