[Xen-devel] [PATCH v3 16/19] xen/arm: Introduce a macro to synchronize SError

2017-03-31 Thread Wei Chen
In previous patches, we have provided the ability to synchronize SErrors in exception entries. But we haven't synchronized SErrors while returning to guest and doing context switch. So we still have two risks: 1. Slipping hypervisor SErrors to guest. For example, hypervisor triggers a SError wh

Re: [Xen-devel] [PATCH v3 16/19] xen/arm: Introduce a macro to synchronize SError

2017-03-31 Thread Julien Grall
Hi Wei, On 31/03/17 14:07, Wei Chen wrote: In previous patches, we have provided the ability to synchronize SErrors in exception entries. But we haven't synchronized SErrors while returning to guest and doing context switch. So we still have two risks: 1. Slipping hypervisor SErrors to guest. F

Re: [Xen-devel] [PATCH v3 16/19] xen/arm: Introduce a macro to synchronize SError

2017-03-31 Thread Stefano Stabellini
On Fri, 31 Mar 2017, Wei Chen wrote: > In previous patches, we have provided the ability to synchronize > SErrors in exception entries. But we haven't synchronized SErrors > while returning to guest and doing context switch. > > So we still have two risks: > 1. Slipping hypervisor SErrors to guest

Re: [Xen-devel] [PATCH v3 16/19] xen/arm: Introduce a macro to synchronize SError

2017-04-05 Thread Wei Chen
Hi Julien, On 2017/3/31 22:33, Julien Grall wrote: Hi Wei, On 31/03/17 14:07, Wei Chen wrote: In previous patches, we have provided the ability to synchronize SErrors in exception entries. But we haven't synchronized SErrors while returning to guest and doing context switch. So we still have

Re: [Xen-devel] [PATCH v3 16/19] xen/arm: Introduce a macro to synchronize SError

2017-04-05 Thread Julien Grall
On 05/04/2017 08:14, Wei Chen wrote: Because the ASSERT I suggested was wrong, sorry for that. It should have been: ASSERT(!cpus_have_cap(feat) && local_abort_is_enabled()); This is because we want abort enabled when the "feature" is not present. This series looks good so far, so I would be

Re: [Xen-devel] [PATCH v3 16/19] xen/arm: Introduce a macro to synchronize SError

2017-04-05 Thread Wei Chen
On 2017/4/5 15:29, Julien Grall wrote: On 05/04/2017 08:14, Wei Chen wrote: Because the ASSERT I suggested was wrong, sorry for that. It should have been: ASSERT(!cpus_have_cap(feat) && local_abort_is_enabled()); This is because we want abort enabled when the "feature" is not present. This

Re: [Xen-devel] [PATCH v3 16/19] xen/arm: Introduce a macro to synchronize SError

2017-04-05 Thread Julien Grall
Hi Wei, On 05/04/2017 08:35, Wei Chen wrote: On 2017/4/5 15:29, Julien Grall wrote: On 05/04/2017 08:14, Wei Chen wrote: Because the ASSERT I suggested was wrong, sorry for that. It should have been: ASSERT(!cpus_have_cap(feat) && local_abort_is_enabled()); This is because we want abort en

Re: [Xen-devel] [PATCH v3 16/19] xen/arm: Introduce a macro to synchronize SError

2017-04-05 Thread Wei Chen
Hi Julien, On 2017/4/5 15:29, Julien Grall wrote: On 05/04/2017 08:14, Wei Chen wrote: Because the ASSERT I suggested was wrong, sorry for that. It should have been: ASSERT(!cpus_have_cap(feat) && local_abort_is_enabled()); This is because we want abort enabled when the "feature" is not pre

Re: [Xen-devel] [PATCH v3 16/19] xen/arm: Introduce a macro to synchronize SError

2017-04-05 Thread Julien Grall
On 05/04/2017 09:08, Wei Chen wrote: Hi Julien, On 2017/4/5 15:29, Julien Grall wrote: On 05/04/2017 08:14, Wei Chen wrote: Because the ASSERT I suggested was wrong, sorry for that. It should have been: ASSERT(!cpus_have_cap(feat) && local_abort_is_enabled()); This is because we want abo

Re: [Xen-devel] [PATCH v3 16/19] xen/arm: Introduce a macro to synchronize SError

2017-04-05 Thread Wei Chen
Hi Julien, On 2017/4/5 16:20, Julien Grall wrote: On 05/04/2017 09:08, Wei Chen wrote: Hi Julien, On 2017/4/5 15:29, Julien Grall wrote: On 05/04/2017 08:14, Wei Chen wrote: Because the ASSERT I suggested was wrong, sorry for that. It should have been: ASSERT(!cpus_have_cap(feat) && loc