>>> On 23.08.17 at 16:21, wrote:
> On 23/08/17 15:18, Jan Beulich wrote:
> On 23.08.17 at 14:42, wrote:
>>> On 23/08/17 11:38, Jan Beulich wrote:
>>> On 23.08.17 at 11:30, wrote:
> On 22/08/17 13:24, Jan Beulich wrote:
> On
On 23/08/17 15:18, Jan Beulich wrote:
On 23.08.17 at 14:42, wrote:
>> On 23/08/17 11:38, Jan Beulich wrote:
>> On 23.08.17 at 11:30, wrote:
On 22/08/17 13:24, Jan Beulich wrote:
On 16.08.17 at 14:52, wrote:
>> @@
>>> On 23.08.17 at 14:42, wrote:
> On 23/08/17 11:38, Jan Beulich wrote:
> On 23.08.17 at 11:30, wrote:
>>> On 22/08/17 13:24, Jan Beulich wrote:
>>> On 16.08.17 at 14:52, wrote:
> @@ -176,7 +210,8 @@ int __init parse_bool(const
On 23/08/17 11:38, Jan Beulich wrote:
On 23.08.17 at 11:30, wrote:
>> On 22/08/17 13:24, Jan Beulich wrote:
>> On 16.08.17 at 14:52, wrote:
@@ -176,7 +210,8 @@ int __init parse_bool(const char *s)
!strcmp("on", s) ||
>>> On 23.08.17 at 11:30, wrote:
> On 22/08/17 13:24, Jan Beulich wrote:
> On 16.08.17 at 14:52, wrote:
>>> @@ -176,7 +210,8 @@ int __init parse_bool(const char *s)
>>> !strcmp("on", s) ||
>>> !strcmp("true", s) ||
>>>
On 22/08/17 13:24, Jan Beulich wrote:
On 16.08.17 at 14:52, wrote:
>> static void __init _cmdline_parse(const char *cmdline)
>> {
>> char opt[128], *optval, *optkey, *q;
>> -const char *p = cmdline;
>> +const char *p = cmdline, *s, *key;
>> const struct
>>> On 16.08.17 at 14:52, wrote:
> static void __init _cmdline_parse(const char *cmdline)
> {
> char opt[128], *optval, *optkey, *q;
> -const char *p = cmdline;
> +const char *p = cmdline, *s, *key;
> const struct kernel_param *param;
> -int bool_assert;
>
Where possible check validity of parameters in _cmdline_parse() and
issue a warning message in case of an error detected.
In order to make sure a custom parameter parsing function really
returns a value (error or success), don't use a void pointer for
storing the function address, but a proper