Re: [Xen-devel] [PATCH v3 39/52] xen: check parameter validity when parsing command line

2017-08-23 Thread Jan Beulich
>>> On 23.08.17 at 16:21, wrote: > On 23/08/17 15:18, Jan Beulich wrote: > On 23.08.17 at 14:42, wrote: >>> On 23/08/17 11:38, Jan Beulich wrote: >>> On 23.08.17 at 11:30, wrote: > On 22/08/17 13:24, Jan Beulich wrote: > On

Re: [Xen-devel] [PATCH v3 39/52] xen: check parameter validity when parsing command line

2017-08-23 Thread Juergen Gross
On 23/08/17 15:18, Jan Beulich wrote: On 23.08.17 at 14:42, wrote: >> On 23/08/17 11:38, Jan Beulich wrote: >> On 23.08.17 at 11:30, wrote: On 22/08/17 13:24, Jan Beulich wrote: On 16.08.17 at 14:52, wrote: >> @@

Re: [Xen-devel] [PATCH v3 39/52] xen: check parameter validity when parsing command line

2017-08-23 Thread Jan Beulich
>>> On 23.08.17 at 14:42, wrote: > On 23/08/17 11:38, Jan Beulich wrote: > On 23.08.17 at 11:30, wrote: >>> On 22/08/17 13:24, Jan Beulich wrote: >>> On 16.08.17 at 14:52, wrote: > @@ -176,7 +210,8 @@ int __init parse_bool(const

Re: [Xen-devel] [PATCH v3 39/52] xen: check parameter validity when parsing command line

2017-08-23 Thread Juergen Gross
On 23/08/17 11:38, Jan Beulich wrote: On 23.08.17 at 11:30, wrote: >> On 22/08/17 13:24, Jan Beulich wrote: >> On 16.08.17 at 14:52, wrote: @@ -176,7 +210,8 @@ int __init parse_bool(const char *s) !strcmp("on", s) ||

Re: [Xen-devel] [PATCH v3 39/52] xen: check parameter validity when parsing command line

2017-08-23 Thread Jan Beulich
>>> On 23.08.17 at 11:30, wrote: > On 22/08/17 13:24, Jan Beulich wrote: > On 16.08.17 at 14:52, wrote: >>> @@ -176,7 +210,8 @@ int __init parse_bool(const char *s) >>> !strcmp("on", s) || >>> !strcmp("true", s) || >>>

Re: [Xen-devel] [PATCH v3 39/52] xen: check parameter validity when parsing command line

2017-08-23 Thread Juergen Gross
On 22/08/17 13:24, Jan Beulich wrote: On 16.08.17 at 14:52, wrote: >> static void __init _cmdline_parse(const char *cmdline) >> { >> char opt[128], *optval, *optkey, *q; >> -const char *p = cmdline; >> +const char *p = cmdline, *s, *key; >> const struct

Re: [Xen-devel] [PATCH v3 39/52] xen: check parameter validity when parsing command line

2017-08-22 Thread Jan Beulich
>>> On 16.08.17 at 14:52, wrote: > static void __init _cmdline_parse(const char *cmdline) > { > char opt[128], *optval, *optkey, *q; > -const char *p = cmdline; > +const char *p = cmdline, *s, *key; > const struct kernel_param *param; > -int bool_assert; >

[Xen-devel] [PATCH v3 39/52] xen: check parameter validity when parsing command line

2017-08-16 Thread Juergen Gross
Where possible check validity of parameters in _cmdline_parse() and issue a warning message in case of an error detected. In order to make sure a custom parameter parsing function really returns a value (error or success), don't use a void pointer for storing the function address, but a proper