Re: [Xen-devel] [PATCH v3 5/7] libxl/libxc: Move libxl_get_cpu_topology()'s hypercall buffer management to libxc

2015-02-23 Thread Boris Ostrovsky
On 02/23/2015 11:44 AM, Ian Campbell wrote: On Mon, 2015-02-09 at 15:04 -0500, Boris Ostrovsky wrote: What is the rationale for this change? libxl is not the right place to handle hypervisor-specific details like buffer management (most, if not all, of other services that libxl provides push

Re: [Xen-devel] [PATCH v3 5/7] libxl/libxc: Move libxl_get_cpu_topology()'s hypercall buffer management to libxc

2015-02-16 Thread Dario Faggioli
On Mon, 2015-02-09 at 15:04 -0500, Boris Ostrovsky wrote: > Signed-off-by: Boris Ostrovsky > Reviewed-by: Dario Faggioli Just one thing: > --- a/tools/libxl/libxl.c > +++ b/tools/libxl/libxl.c > @@ -5072,38 +5072,23 @@ int libxl_get_physinfo(libxl_ctx *ctx, libxl_physinfo > *physinfo) > libxl

Re: [Xen-devel] [PATCH v3 5/7] libxl/libxc: Move libxl_get_cpu_topology()'s hypercall buffer management to libxc

2015-02-10 Thread Boris Ostrovsky
On 02/10/2015 06:23 AM, Andrew Cooper wrote: diff --git a/tools/libxc/include/xenctrl.h b/tools/libxc/include/xenctrl.h index 0cb6743..d94571d 100644 --- a/tools/libxc/include/xenctrl.h +++ b/tools/libxc/include/xenctrl.h @@ -1226,7 +1226,7 @@ int xc_readconsolering(xc_interface *xch, int xc

Re: [Xen-devel] [PATCH v3 5/7] libxl/libxc: Move libxl_get_cpu_topology()'s hypercall buffer management to libxc

2015-02-10 Thread Andrew Cooper
On 09/02/15 20:04, Boris Ostrovsky wrote: > Signed-off-by: Boris Ostrovsky > --- > tools/libxc/include/xenctrl.h |4 +- > tools/libxc/xc_misc.c | 23 +++- > tools/libxl/libxl.c | 32 +-- > tools/misc/xenpm.c|

[Xen-devel] [PATCH v3 5/7] libxl/libxc: Move libxl_get_cpu_topology()'s hypercall buffer management to libxc

2015-02-09 Thread Boris Ostrovsky
Signed-off-by: Boris Ostrovsky --- tools/libxc/include/xenctrl.h |4 +- tools/libxc/xc_misc.c | 23 +++- tools/libxl/libxl.c | 32 +-- tools/misc/xenpm.c| 51 - tools/python