Re: [Xen-devel] [PATCH v4] x86/apicv: Fix wrong IPI suppression during posted interrupt delivery

2017-03-05 Thread Xuquan (Quan Xu)
On March 06, 2017 6:50 AM, Chao Gao wrote: >On Mon, Mar 06, 2017 at 03:53:44AM +, Xuquan (Quan Xu) wrote: >>On March 03, 2017 10:36 AM, Chao Gao wrote: >>>+/* >>>+ * Just like vcpu_kick(), nothing is needed for the following two cases: >>>+ * 1. The target vCPU is not running, meani

Re: [Xen-devel] [PATCH v4] x86/apicv: Fix wrong IPI suppression during posted interrupt delivery

2017-03-05 Thread Chao Gao
On Mon, Mar 06, 2017 at 03:53:44AM +, Xuquan (Quan Xu) wrote: >On March 03, 2017 10:36 AM, Chao Gao wrote: >>+/* >>+ * Just like vcpu_kick(), nothing is needed for the following two cases: >>+ * 1. The target vCPU is not running, meaning it is blocked or runnable. >>+ * 2. The t

Re: [Xen-devel] [PATCH v4] x86/apicv: Fix wrong IPI suppression during posted interrupt delivery

2017-03-05 Thread Xuquan (Quan Xu)
On March 03, 2017 10:36 AM, Chao Gao wrote: >__vmx_deliver_posted_interrupt() wrongly used a softirq bit to decide >whether to suppress an IPI. Its logic was: the first time an IPI was sent, we >set >the softirq bit. Next time, we would check that softirq bit before sending >another IPI. If the 1s

[Xen-devel] [PATCH v4] x86/apicv: Fix wrong IPI suppression during posted interrupt delivery

2017-03-03 Thread Chao Gao
__vmx_deliver_posted_interrupt() wrongly used a softirq bit to decide whether to suppress an IPI. Its logic was: the first time an IPI was sent, we set the softirq bit. Next time, we would check that softirq bit before sending another IPI. If the 1st IPI arrived at the pCPU which was in non-root mo