Re: [Xen-devel] [PATCH v4] x86/apicv: fix RTC periodic timer and apicv issue

2017-01-04 Thread Jan Beulich
>>> On 04.01.17 at 02:58, wrote: > """ > intack.vector is the highest priority vector. So we set eoi_exit_bitmap > for intack.vector - give a chance to post periodic time interrupts when > periodic time interrupts become the highest one. > """ Sounds fine. Jan _

Re: [Xen-devel] [PATCH v4] x86/apicv: fix RTC periodic timer and apicv issue

2017-01-03 Thread Xuquan (Quan Xu)
On January 03, 2017 4:23 PM, Jan Beulich wrote: On 03.01.17 at 09:15, wrote: > >> >>>-Original Message- >>>From: Jan Beulich [mailto:jbeul...@suse.com] >>>Sent: Tuesday, January 03, 2017 3:35 PM >>>To: Xuquan (Quan Xu) >>>Cc: Andrew Cooper; George Dunlap; yang.zhang...@gmail.com; Chao

Re: [Xen-devel] [PATCH v4] x86/apicv: fix RTC periodic timer and apicv issue

2017-01-03 Thread Jan Beulich
>>> On 03.01.17 at 09:15, wrote: > >>-Original Message- >>From: Jan Beulich [mailto:jbeul...@suse.com] >>Sent: Tuesday, January 03, 2017 3:35 PM >>To: Xuquan (Quan Xu) >>Cc: Andrew Cooper; George Dunlap; yang.zhang...@gmail.com; Chao Gao; >>Jun Nakajima; Kevin Tian; Lan Tianyu; xen-devel

Re: [Xen-devel] [PATCH v4] x86/apicv: fix RTC periodic timer and apicv issue

2017-01-03 Thread Xuquan (Quan Xu)
>-Original Message- >From: Jan Beulich [mailto:jbeul...@suse.com] >Sent: Tuesday, January 03, 2017 3:35 PM >To: Xuquan (Quan Xu) >Cc: Andrew Cooper; George Dunlap; yang.zhang...@gmail.com; Chao Gao; >Jun Nakajima; Kevin Tian; Lan Tianyu; xen-devel@lists.xen.org >Subject: RE: [PATCH v4] x8

Re: [Xen-devel] [PATCH v4] x86/apicv: fix RTC periodic timer and apicv issue

2017-01-02 Thread Jan Beulich
>>> On 23.12.16 at 13:24, wrote: > On December 22, 2016 4:12 PM, Jan Beulich wrote: > On 21.12.16 at 06:44, wrote: >>> --- a/xen/arch/x86/hvm/vmx/intr.c >>> +++ b/xen/arch/x86/hvm/vmx/intr.c >>> @@ -315,9 +315,13 @@ void vmx_intr_assist(void) >>> * Set eoi_exit_bitmap for periodic ti

Re: [Xen-devel] [PATCH v4] x86/apicv: fix RTC periodic timer and apicv issue

2016-12-23 Thread Xuquan (Quan Xu)
On December 22, 2016 4:12 PM, Jan Beulich wrote: On 21.12.16 at 06:44, wrote: >> --- a/xen/arch/x86/hvm/vmx/intr.c >> +++ b/xen/arch/x86/hvm/vmx/intr.c >> @@ -315,9 +315,13 @@ void vmx_intr_assist(void) >> * Set eoi_exit_bitmap for periodic timer interrup to cause >EOI-induced VM >>

Re: [Xen-devel] [PATCH v4] x86/apicv: fix RTC periodic timer and apicv issue

2016-12-22 Thread Chao Gao
On Thu, Dec 22, 2016 at 03:48:48PM +0800, Tian, Kevin wrote: >sent too quick. I meant please add your tested-by here. :-) Yes, of course. Tested-by: Chao Gao > >> From: Tian, Kevin >> Sent: Thursday, December 22, 2016 3:48 PM >> >> Thanks a lot! >> >> > From: Gao, Chao >> > Sent: Thursday, Dec

Re: [Xen-devel] [PATCH v4] x86/apicv: fix RTC periodic timer and apicv issue

2016-12-22 Thread Jan Beulich
>>> On 21.12.16 at 06:44, wrote: > --- a/xen/arch/x86/hvm/vmx/intr.c > +++ b/xen/arch/x86/hvm/vmx/intr.c > @@ -315,9 +315,13 @@ void vmx_intr_assist(void) > * Set eoi_exit_bitmap for periodic timer interrup to cause > EOI-induced VM > * exit, then pending periodic time interrups

Re: [Xen-devel] [PATCH v4] x86/apicv: fix RTC periodic timer and apicv issue

2016-12-21 Thread Tian, Kevin
> From: Xuquan (Quan Xu) [mailto:xuqu...@huawei.com] > Sent: Wednesday, December 21, 2016 1:44 PM > > When Xen apicv is enabled, wall clock time is faster on Windows7-32 > guest with high payload (with 2vCPU, captured from xentrace, in > high payload, the count of IPI interrupt increases rapidly b

Re: [Xen-devel] [PATCH v4] x86/apicv: fix RTC periodic timer and apicv issue

2016-12-21 Thread Tian, Kevin
sent too quick. I meant please add your tested-by here. :-) > From: Tian, Kevin > Sent: Thursday, December 22, 2016 3:48 PM > > Thanks a lot! > > > From: Gao, Chao > > Sent: Thursday, December 22, 2016 4:02 AM > > > > Hi, xuquan. > > I have tested it on my skylake server. W/o this patch the inac

Re: [Xen-devel] [PATCH v4] x86/apicv: fix RTC periodic timer and apicv issue

2016-12-21 Thread Tian, Kevin
Thanks a lot! > From: Gao, Chao > Sent: Thursday, December 22, 2016 4:02 AM > > Hi, xuquan. > I have tested it on my skylake server. W/o this patch the inaccurate > wall clock time issue only exists in Win7-32 guest. Win7-64, Win8-32, Win8-64, > Win10-32 ,Win10-64 and linux-4.8.0+ guests don't ha

Re: [Xen-devel] [PATCH v4] x86/apicv: fix RTC periodic timer and apicv issue

2016-12-21 Thread Xuquan (Quan Xu)
Hi Chao, To me, it is sufficient.. thanks for your verification!! Quan On December 22, 2016 4:02 AM, Chao Gao wrote: >Hi, xuquan. >I have tested it on my skylake server. W/o this patch the inaccurate wall >clock time issue only exists in Win7-32 guest. Win7-64, Win8-32, Win8-64, >Win10-32 ,Win10

Re: [Xen-devel] [PATCH v4] x86/apicv: fix RTC periodic timer and apicv issue

2016-12-21 Thread Chao Gao
Hi, xuquan. I have tested it on my skylake server. W/o this patch the inaccurate wall clock time issue only exists in Win7-32 guest. Win7-64, Win8-32, Win8-64, Win10-32 ,Win10-64 and linux-4.8.0+ guests don't have this issue. W/ this v4 patch, the issue disappears in Win7-32 guest and no wall lock

[Xen-devel] [PATCH v4] x86/apicv: fix RTC periodic timer and apicv issue

2016-12-20 Thread Xuquan (Quan Xu)
When Xen apicv is enabled, wall clock time is faster on Windows7-32 guest with high payload (with 2vCPU, captured from xentrace, in high payload, the count of IPI interrupt increases rapidly between these vCPUs). If IPI intrrupt (vector 0xe1) and periodic timer interrupt (vector 0xd1) are both pen