Re: [Xen-devel] [PATCH v4 10/10] vt-d: propagate error up to ME phantom function mapping and unmapping

2016-05-12 Thread Xu, Quan
On May 12, 2016 4:45 PM, Jan Beulich wrote: > >>> On 12.05.16 at 07:16, wrote: > > Taken together, there are 3 call trees to me_wifi_quirk(): > > > > 1). > > ...--me_wifi_quirk()--domain_context_mapping_one()-- > domain_context_map > > ping()--se > >

Re: [Xen-devel] [PATCH v4 10/10] vt-d: propagate error up to ME phantom function mapping and unmapping

2016-05-12 Thread Jan Beulich
>>> On 12.05.16 at 07:16, wrote: > Taken together, there are 3 call trees to me_wifi_quirk(): > > 1). > ...--me_wifi_quirk()--domain_context_mapping_one()--domain_context_mapping()--se > tup_hwdom_device() > > There is no use in calling this function if

Re: [Xen-devel] [PATCH v4 10/10] vt-d: propagate error up to ME phantom function mapping and unmapping

2016-05-11 Thread Xu, Quan
On May 11, 2016 5:07 PM, Jan Beulich wrote: > >>> On 11.05.16 at 10:35, wrote: > > On May 10, 2016 5:29 PM, Jan Beulich wrote: > >> >>> On 06.05.16 at 10:54, wrote: > >> > @@ -1430,7 +1430,12 @@ int

Re: [Xen-devel] [PATCH v4 10/10] vt-d: propagate error up to ME phantom function mapping and unmapping

2016-05-11 Thread Jan Beulich
>>> On 11.05.16 at 10:35, wrote: > On May 10, 2016 5:29 PM, Jan Beulich wrote: >> >>> On 06.05.16 at 10:54, wrote: >> > @@ -1430,7 +1430,12 @@ int domain_context_mapping_one( >> > unmap_vtd_domain_page(context_entries); >> > >> >

Re: [Xen-devel] [PATCH v4 10/10] vt-d: propagate error up to ME phantom function mapping and unmapping

2016-05-11 Thread Xu, Quan
On May 10, 2016 5:29 PM, Jan Beulich wrote: > >>> On 06.05.16 at 10:54, wrote: > > @@ -1430,7 +1430,12 @@ int domain_context_mapping_one( > > unmap_vtd_domain_page(context_entries); > > > > if ( !seg ) > > -me_wifi_quirk(domain, bus, devfn,

Re: [Xen-devel] [PATCH v4 10/10] vt-d: propagate error up to ME phantom function mapping and unmapping

2016-05-10 Thread Jan Beulich
>>> On 06.05.16 at 10:54, wrote: > @@ -1430,7 +1430,12 @@ int domain_context_mapping_one( > unmap_vtd_domain_page(context_entries); > > if ( !seg ) > -me_wifi_quirk(domain, bus, devfn, MAP_ME_PHANTOM_FUNC); > +{ > +ret = me_wifi_quirk(domain,

[Xen-devel] [PATCH v4 10/10] vt-d: propagate error up to ME phantom function mapping and unmapping

2016-05-06 Thread Quan Xu
Propagate the IOMMU Device-TLB flush error up to ME phantom function mapping and unmapping. Signed-off-by: Quan Xu CC: Jan Beulich CC: Kevin Tian CC: Feng Wu --- xen/drivers/passthrough/vtd/extern.h | 3 ++-