Re: [Xen-devel] [PATCH v4 10/17] x86/hvm: revert 82ed8716b "fix direct PCI port I/O emulation retry...

2015-06-24 Thread Paul Durrant
> -Original Message- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: 24 June 2015 16:21 > To: Paul Durrant > Cc: Andrew Cooper; xen-de...@lists.xenproject.org; Keir (Xen.org) > Subject: Re: [PATCH v4 10/17] x86/hvm: revert 82ed8716b "fix direct PCI port > I/O emulation retry... > >

Re: [Xen-devel] [PATCH v4 10/17] x86/hvm: revert 82ed8716b "fix direct PCI port I/O emulation retry...

2015-06-24 Thread Jan Beulich
>>> On 24.06.15 at 13:24, wrote: > @@ -288,17 +272,66 @@ static int hvmemul_do_io_addr( > bool_t is_mmio, paddr_t addr, unsigned long *reps, > unsigned int size, uint8_t dir, bool_t df, paddr_t ram_gpa) > { > -struct page_info *ram_page; > +struct vcpu *v = current; > +unsig

[Xen-devel] [PATCH v4 10/17] x86/hvm: revert 82ed8716b "fix direct PCI port I/O emulation retry...

2015-06-24 Thread Paul Durrant
...and error handling" NOTE: A straight reversion was not possible because of subsequent changes in the code so this at least partially a manual reversion. By limiting hvmemul_do_io_addr() to reps falling within the pages on which a reference has already been taken, we can guarantee that ca