Re: [Xen-devel] [PATCH v4 12/17] x86/hvm: split I/O completion handling from state model

2015-06-25 Thread Paul Durrant
-Original Message- From: Jan Beulich [mailto:jbeul...@suse.com] Sent: 25 June 2015 10:41 To: Paul Durrant Cc: Andrew Cooper; xen-de...@lists.xenproject.org; Keir (Xen.org) Subject: Re: [PATCH v4 12/17] x86/hvm: split I/O completion handling from state model On 24.06.15 at 13:24,

Re: [Xen-devel] [PATCH v4 12/17] x86/hvm: split I/O completion handling from state model

2015-06-25 Thread Jan Beulich
On 24.06.15 at 13:24, paul.durr...@citrix.com wrote: @@ -428,26 +429,12 @@ static void hvm_io_assist(ioreq_t *p) vio-io_state = HVMIO_completed; vio-io_data = p-data; break; -case HVMIO_handle_mmio_awaiting_completion: -vio-io_state = HVMIO_completed;

[Xen-devel] [PATCH v4 12/17] x86/hvm: split I/O completion handling from state model

2015-06-24 Thread Paul Durrant
The state of in-flight I/O and how its completion will be handled are logically separate and conflating the two makes the code unnecessarily confusing. Signed-off-by: Paul Durrant paul.durr...@citrix.com Cc: Keir Fraser k...@xen.org Cc: Jan Beulich jbeul...@suse.com Cc: Andrew Cooper