Re: [Xen-devel] [PATCH v4 20/21] libxl/acpi: Build ACPI tables for HVMlite guests

2016-09-22 Thread Wei Liu
On Thu, Sep 22, 2016 at 11:57:18AM -0400, Boris Ostrovsky wrote: > On 09/22/2016 06:53 AM, Wei Liu wrote: > > > >> diff --git a/tools/libxl/Makefile b/tools/libxl/Makefile > >> index 90427ff..336358c 100644 > >> --- a/tools/libxl/Makefile > >> +++ b/tools/libxl/Makefile > >> @@ -75,7 +75,21 @@ else

Re: [Xen-devel] [PATCH v4 20/21] libxl/acpi: Build ACPI tables for HVMlite guests

2016-09-22 Thread Boris Ostrovsky
On 09/22/2016 06:53 AM, Wei Liu wrote: > >> diff --git a/tools/libxl/Makefile b/tools/libxl/Makefile >> index 90427ff..336358c 100644 >> --- a/tools/libxl/Makefile >> +++ b/tools/libxl/Makefile >> @@ -75,7 +75,21 @@ else >> LIBXL_OBJS-y += libxl_no_colo.o >> endif >> >> -LIBXL_OBJS-$(CONFIG_X86

Re: [Xen-devel] [PATCH v4 20/21] libxl/acpi: Build ACPI tables for HVMlite guests

2016-09-22 Thread Wei Liu
On Mon, Sep 19, 2016 at 08:19:38PM -0400, Boris Ostrovsky wrote: > Signed-off-by: Boris Ostrovsky The code mostly looks good. Some nits below. > --- > Changes in v4: > * Remove allocation-specific fields from struct acpi_ctxt and use > an enclosing struct libxl_acpi_ctxt. > * Use private stru

Re: [Xen-devel] [PATCH v4 20/21] libxl/acpi: Build ACPI tables for HVMlite guests

2016-09-22 Thread Jan Beulich
>>> On 21.09.16 at 18:38, wrote: > I don't understand though why we can't rely on util.h after the move. Once you move the component, it should be self-contained. Jan ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH v4 20/21] libxl/acpi: Build ACPI tables for HVMlite guests

2016-09-21 Thread Boris Ostrovsky
On 09/21/2016 12:02 PM, Jan Beulich wrote: On 21.09.16 at 17:34, wrote: >> On 09/21/2016 11:16 AM, Jan Beulich wrote: >> On 21.09.16 at 17:09, wrote: On 09/21/2016 07:33 AM, Jan Beulich wrote: On 20.09.16 at 02:19, wrote: >> --- a/tools/libacpi/build.c >> +++ b/too

Re: [Xen-devel] [PATCH v4 20/21] libxl/acpi: Build ACPI tables for HVMlite guests

2016-09-21 Thread Jan Beulich
>>> On 21.09.16 at 17:34, wrote: > On 09/21/2016 11:16 AM, Jan Beulich wrote: > On 21.09.16 at 17:09, wrote: >>> On 09/21/2016 07:33 AM, Jan Beulich wrote: >>> On 20.09.16 at 02:19, wrote: > --- a/tools/libacpi/build.c > +++ b/tools/libacpi/build.c > @@ -20,6 +20,7 @@ >

Re: [Xen-devel] [PATCH v4 20/21] libxl/acpi: Build ACPI tables for HVMlite guests

2016-09-21 Thread Boris Ostrovsky
On 09/21/2016 11:16 AM, Jan Beulich wrote: On 21.09.16 at 17:09, wrote: >> On 09/21/2016 07:33 AM, Jan Beulich wrote: >> On 20.09.16 at 02:19, wrote: --- a/tools/libacpi/build.c +++ b/tools/libacpi/build.c @@ -20,6 +20,7 @@ #include "ssdt_s4.h" #include "ssdt_t

Re: [Xen-devel] [PATCH v4 20/21] libxl/acpi: Build ACPI tables for HVMlite guests

2016-09-21 Thread Jan Beulich
>>> On 21.09.16 at 17:09, wrote: > On 09/21/2016 07:33 AM, Jan Beulich wrote: > On 20.09.16 at 02:19, wrote: >>> --- a/tools/libacpi/build.c >>> +++ b/tools/libacpi/build.c >>> @@ -20,6 +20,7 @@ >>> #include "ssdt_s4.h" >>> #include "ssdt_tpm.h" >>> #include "ssdt_pm.h" >>> +#include >> .

Re: [Xen-devel] [PATCH v4 20/21] libxl/acpi: Build ACPI tables for HVMlite guests

2016-09-21 Thread Boris Ostrovsky
On 09/21/2016 07:33 AM, Jan Beulich wrote: On 20.09.16 at 02:19, wrote: >> Signed-off-by: Boris Ostrovsky > libacpi parts > Acked-by: Jan Beulich > albeit ... > > >> --- a/tools/libacpi/build.c >> +++ b/tools/libacpi/build.c >> @@ -20,6 +20,7 @@ >> #include "ssdt_s4.h" >> #include "ssdt_t

Re: [Xen-devel] [PATCH v4 20/21] libxl/acpi: Build ACPI tables for HVMlite guests

2016-09-21 Thread Jan Beulich
>>> On 20.09.16 at 02:19, wrote: > Signed-off-by: Boris Ostrovsky libacpi parts Acked-by: Jan Beulich albeit ... > --- a/tools/libacpi/build.c > +++ b/tools/libacpi/build.c > @@ -20,6 +20,7 @@ > #include "ssdt_s4.h" > #include "ssdt_tpm.h" > #include "ssdt_pm.h" > +#include ... I don't r

[Xen-devel] [PATCH v4 20/21] libxl/acpi: Build ACPI tables for HVMlite guests

2016-09-19 Thread Boris Ostrovsky
Signed-off-by: Boris Ostrovsky --- Changes in v4: * Remove allocation-specific fields from struct acpi_ctxt and use an enclosing struct libxl_acpi_ctxt. * Use private struct hvminfo (to deal with constified struct acpi_config->hvminfo) .gitignore | 12 ++- tools/libacpi/bu