Re: [Xen-devel] [PATCH v4 7/7] xen/pciback: Restore configuration space when detaching from a guest.

2014-12-03 Thread Konrad Rzeszutek Wilk
On Tue, Dec 02, 2014 at 06:11:50PM -0500, Boris Ostrovsky wrote: On 11/21/2014 05:17 PM, Konrad Rzeszutek Wilk wrote: The commit xen/pciback: Don't deadlock when unbinding. was using the version of pci_reset_function which would lock the device lock. That is no good as we can dead-lock. As

Re: [Xen-devel] [PATCH v4 7/7] xen/pciback: Restore configuration space when detaching from a guest.

2014-12-02 Thread Boris Ostrovsky
On 11/21/2014 05:17 PM, Konrad Rzeszutek Wilk wrote: The commit xen/pciback: Don't deadlock when unbinding. was using the version of pci_reset_function which would lock the device lock. That is no good as we can dead-lock. As such we swapped to using the lock-less version and requiring that the

Re: [Xen-devel] [PATCH v4 7/7] xen/pciback: Restore configuration space when detaching from a guest.

2014-12-01 Thread David Vrabel
On 21/11/14 22:17, Konrad Rzeszutek Wilk wrote: The commit xen/pciback: Don't deadlock when unbinding. was using the version of pci_reset_function which would lock the device lock. That is no good as we can dead-lock. As such we swapped to using the lock-less version and requiring that the

Re: [Xen-devel] [PATCH v4 7/7] xen/pciback: Restore configuration space when detaching from a guest.

2014-12-01 Thread Konrad Rzeszutek Wilk
On Mon, Dec 01, 2014 at 02:14:56PM +, David Vrabel wrote: On 21/11/14 22:17, Konrad Rzeszutek Wilk wrote: The commit xen/pciback: Don't deadlock when unbinding. was using the version of pci_reset_function which would lock the device lock. That is no good as we can dead-lock. As such we

[Xen-devel] [PATCH v4 7/7] xen/pciback: Restore configuration space when detaching from a guest.

2014-11-21 Thread Konrad Rzeszutek Wilk
The commit xen/pciback: Don't deadlock when unbinding. was using the version of pci_reset_function which would lock the device lock. That is no good as we can dead-lock. As such we swapped to using the lock-less version and requiring that the callers of 'pcistub_put_pci_dev' take the device lock.