Re: [Xen-devel] [PATCH v4 8/8] x86/vm_event: Add HVM debug exception vm_events

2016-06-01 Thread Tamas K Lengyel
On Wed, Jun 1, 2016 at 4:17 PM, Andrew Cooper wrote: > On 01/06/2016 22:46, Tamas K Lengyel wrote: >> On Tue, May 31, 2016 at 1:59 AM, Jan Beulich wrote: >> On 30.05.16 at 22:13, wrote: On Mon, May 30, 2016 at 8:16 AM, Jan Beulich wrote: On 30.05.16 at 00:37, wrote: >> @@

Re: [Xen-devel] [PATCH v4 8/8] x86/vm_event: Add HVM debug exception vm_events

2016-06-01 Thread Andrew Cooper
On 01/06/2016 22:46, Tamas K Lengyel wrote: > On Tue, May 31, 2016 at 1:59 AM, Jan Beulich wrote: > On 30.05.16 at 22:13, wrote: >>> On Mon, May 30, 2016 at 8:16 AM, Jan Beulich wrote: >>> On 30.05.16 at 00:37, wrote: > @@ -3393,8 +3409,9 @@ void vmx_vmexit_handler(struct cpu_user_r

Re: [Xen-devel] [PATCH v4 8/8] x86/vm_event: Add HVM debug exception vm_events

2016-06-01 Thread Tamas K Lengyel
On Tue, May 31, 2016 at 1:59 AM, Jan Beulich wrote: On 30.05.16 at 22:13, wrote: >> On Mon, May 30, 2016 at 8:16 AM, Jan Beulich wrote: >> On 30.05.16 at 00:37, wrote: @@ -3393,8 +3409,9 @@ void vmx_vmexit_handler(struct cpu_user_regs *regs) } e

Re: [Xen-devel] [PATCH v4 8/8] x86/vm_event: Add HVM debug exception vm_events

2016-05-31 Thread Jan Beulich
>>> On 30.05.16 at 22:13, wrote: > On Mon, May 30, 2016 at 8:16 AM, Jan Beulich wrote: > On 30.05.16 at 00:37, wrote: >>> @@ -3393,8 +3409,9 @@ void vmx_vmexit_handler(struct cpu_user_regs *regs) >>> } >>> else { >>> int handled = >>> -

Re: [Xen-devel] [PATCH v4 8/8] x86/vm_event: Add HVM debug exception vm_events

2016-05-30 Thread Andrew Cooper
>>> @@ -3393,8 +3409,9 @@ void vmx_vmexit_handler(struct cpu_user_regs *regs) >>> } >>> else { >>> int handled = >>> -hvm_monitor_breakpoint(regs->eip, >>> - >>> HVM_MONITOR_SOFTWARE_BREAKPOIN

Re: [Xen-devel] [PATCH v4 8/8] x86/vm_event: Add HVM debug exception vm_events

2016-05-30 Thread Tamas K Lengyel
On Mon, May 30, 2016 at 8:16 AM, Jan Beulich wrote: On 30.05.16 at 00:37, wrote: >> @@ -117,7 +133,11 @@ int hvm_monitor_breakpoint(unsigned long rip, >> >> req.vcpu_id = curr->vcpu_id; >> >> -return vm_event_monitor_traps(curr, 1, &req); >> +rc = vm_event_monitor_traps(curr, sy

Re: [Xen-devel] [PATCH v4 8/8] x86/vm_event: Add HVM debug exception vm_events

2016-05-30 Thread Jan Beulich
>>> On 30.05.16 at 00:37, wrote: > @@ -117,7 +133,11 @@ int hvm_monitor_breakpoint(unsigned long rip, > > req.vcpu_id = curr->vcpu_id; > > -return vm_event_monitor_traps(curr, 1, &req); > +rc = vm_event_monitor_traps(curr, sync, &req); > +if ( type == HVM_MONITOR_DEBUG_EXCEPTI

Re: [Xen-devel] [PATCH v4 8/8] x86/vm_event: Add HVM debug exception vm_events

2016-05-30 Thread Razvan Cojocaru
On 05/30/2016 01:37 AM, Tamas K Lengyel wrote: > Since in-guest debug exceptions are now unconditionally trapped to Xen, adding > a hook for vm_event subscribers to tap into this new always-on guest event. We > rename along the way hvm_event_breakpoint_type to hvm_event_type to better > match the v

[Xen-devel] [PATCH v4 8/8] x86/vm_event: Add HVM debug exception vm_events

2016-05-29 Thread Tamas K Lengyel
Since in-guest debug exceptions are now unconditionally trapped to Xen, adding a hook for vm_event subscribers to tap into this new always-on guest event. We rename along the way hvm_event_breakpoint_type to hvm_event_type to better match the various events that can be passed with it. We also intro