Re: [Xen-devel] [PATCH v4 8/9] arm/mem_access: Add short-descriptor based gpt

2017-06-26 Thread Sergej Proskurin
Hi Julien, [...] + +/* + * As we have considered up to 2 MSBs of the GVA for mapping the first + * level translation table, we need to make sure that we limit the table + * offset that is is indexed by GVA<31-n:20> to max 10 bits to avoid >

Re: [Xen-devel] [PATCH v4 8/9] arm/mem_access: Add short-descriptor based gpt

2017-06-23 Thread Julien Grall
On 06/23/2017 08:09 PM, Sergej Proskurin wrote: Hi Julien, Hi Sergej, [...] Looking at the code, I see very limited point of having the offsets array as you don't use a loop and also use each offset in a single place. +((paddr_t)(gva >> 20) & ((1ULL << (12 - n)) - 1)), Don'

Re: [Xen-devel] [PATCH v4 8/9] arm/mem_access: Add short-descriptor based gpt

2017-06-23 Thread Sergej Proskurin
Hi Julien, [...] > > Looking at the code, I see very limited point of having the offsets > array as you don't use a loop and also use each offset in a single place. > >> +((paddr_t)(gva >> 20) & ((1ULL << (12 - n)) - 1)), > Don't you think it is more readable to have the GVA offsets at

Re: [Xen-devel] [PATCH v4 8/9] arm/mem_access: Add short-descriptor based gpt

2017-06-22 Thread Julien Grall
Hi Sergej, On 20/06/17 21:33, Sergej Proskurin wrote: This commit adds functionality to walk the guest's page tables using the short-descriptor translation table format for both ARMv7 and ARMv8. The implementation is based on ARM DDI 0487B-a J1-6002 and ARM DDI 0406C-b B3-1506. Signed-off-by: S

[Xen-devel] [PATCH v4 8/9] arm/mem_access: Add short-descriptor based gpt

2017-06-20 Thread Sergej Proskurin
This commit adds functionality to walk the guest's page tables using the short-descriptor translation table format for both ARMv7 and ARMv8. The implementation is based on ARM DDI 0487B-a J1-6002 and ARM DDI 0406C-b B3-1506. Signed-off-by: Sergej Proskurin --- Cc: Stefano Stabellini Cc: Julien G