Re: [Xen-devel] [PATCH v5 02/10] IOMMU: handle IOMMU mapping and unmapping failures

2016-05-24 Thread Xu, Quan
On May 23, 2016 9:41 PM, Jan Beulich wrote: > >>> On 18.05.16 at 10:08, wrote: > > No spamming can occur. > > May I suggest "No spamming of the log can occur", to set some context for > what follows? > Make sense. > > --- a/xen/drivers/passthrough/iommu.c > > +++ b/xen/drivers/passthrough/iom

Re: [Xen-devel] [PATCH v5 02/10] IOMMU: handle IOMMU mapping and unmapping failures

2016-05-23 Thread Jan Beulich
>>> On 18.05.16 at 10:08, wrote: > No spamming can occur. May I suggest "No spamming of the log can occur", to set some context for what follows? > --- a/xen/drivers/passthrough/iommu.c > +++ b/xen/drivers/passthrough/iommu.c > @@ -240,21 +240,49 @@ int iommu_map_page(struct domain *d, unsigned

[Xen-devel] [PATCH v5 02/10] IOMMU: handle IOMMU mapping and unmapping failures

2016-05-18 Thread Quan Xu
Treat IOMMU mapping and unmapping failures as a fatal to the DomU If IOMMU mapping and unmapping failed, crash the DomU and propagate the error up to the call trees. No spamming can occur. For DomU, we avoid logging any message for already dying domains. For Dom0, that'll still be more verbose tha