Re: [Xen-devel] [PATCH v5 04/13] pvh/acpi: Install handlers for ACPI-related PVH IO accesses

2016-12-20 Thread Boris Ostrovsky
On 12/20/2016 09:55 AM, Andrew Cooper wrote: >>> Is this file is not supposed to be used by anyone outside of the Xen tree? >> I don't think so, no. In any event - prior additions did not do >> any precautions to guard possible foreign consumers. Maybe >> Andrew has an opinion here ... > Our

Re: [Xen-devel] [PATCH v5 04/13] pvh/acpi: Install handlers for ACPI-related PVH IO accesses

2016-12-20 Thread Andrew Cooper
On 20/12/2016 14:45, Jan Beulich wrote: On 20.12.16 at 15:16, wrote: >> On 12/20/2016 09:10 AM, Jan Beulich wrote: >> On 20.12.16 at 15:03, wrote: On 12/20/2016 06:24 AM, Jan Beulich wrote: On 17.12.16 at 00:18,

Re: [Xen-devel] [PATCH v5 04/13] pvh/acpi: Install handlers for ACPI-related PVH IO accesses

2016-12-20 Thread Jan Beulich
>>> On 20.12.16 at 15:16, wrote: > On 12/20/2016 09:10 AM, Jan Beulich wrote: > On 20.12.16 at 15:03, wrote: >>> On 12/20/2016 06:24 AM, Jan Beulich wrote: >>> On 17.12.16 at 00:18, wrote: > ---

Re: [Xen-devel] [PATCH v5 04/13] pvh/acpi: Install handlers for ACPI-related PVH IO accesses

2016-12-20 Thread Boris Ostrovsky
On 12/20/2016 09:10 AM, Jan Beulich wrote: On 20.12.16 at 15:03, wrote: >> On 12/20/2016 06:24 AM, Jan Beulich wrote: >> On 17.12.16 at 00:18, wrote: --- a/xen/include/public/arch-x86/hvm/save.h +++

Re: [Xen-devel] [PATCH v5 04/13] pvh/acpi: Install handlers for ACPI-related PVH IO accesses

2016-12-20 Thread Jan Beulich
>>> On 20.12.16 at 15:03, wrote: > On 12/20/2016 06:24 AM, Jan Beulich wrote: > On 17.12.16 at 00:18, wrote: >>> --- a/xen/include/public/arch-x86/hvm/save.h >>> +++ b/xen/include/public/arch-x86/hvm/save.h >>> @@ -527,7 +527,37 @@

Re: [Xen-devel] [PATCH v5 04/13] pvh/acpi: Install handlers for ACPI-related PVH IO accesses

2016-12-20 Thread Boris Ostrovsky
On 12/20/2016 06:24 AM, Jan Beulich wrote: On 17.12.16 at 00:18, wrote: >> --- a/xen/include/public/arch-x86/hvm/save.h >> +++ b/xen/include/public/arch-x86/hvm/save.h >> @@ -527,7 +527,37 @@ DECLARE_HVM_SAVE_TYPE(HPET, 12, struct hvm_hw_hpet); >> /* >> * PM

Re: [Xen-devel] [PATCH v5 04/13] pvh/acpi: Install handlers for ACPI-related PVH IO accesses

2016-12-20 Thread Jan Beulich
>>> On 17.12.16 at 00:18, wrote: > --- a/xen/include/public/arch-x86/hvm/save.h > +++ b/xen/include/public/arch-x86/hvm/save.h > @@ -527,7 +527,37 @@ DECLARE_HVM_SAVE_TYPE(HPET, 12, struct hvm_hw_hpet); > /* > * PM timer > */ > +#if __XEN_INTERFACE_VERSION__ >=

[Xen-devel] [PATCH v5 04/13] pvh/acpi: Install handlers for ACPI-related PVH IO accesses

2016-12-16 Thread Boris Ostrovsky
PVH guests will have ACPI accesses emulated by the hypervisor as opposed to QEMU (as is the case for HVM guests). This patch installs handler for accesses to PM1A, GPE0 (which is added to struct hvm_hw_acpi) and VCPU map. Logic for the handler will be provided by a later patch. Whether or not the