Re: [Xen-devel] [PATCH v5 06/16] x86/boot/reloc: create generic alloc and copy functions

2016-09-06 Thread Doug Goldstein
On 8/30/16 9:32 AM, Daniel Kiper wrote: > On Thu, Aug 25, 2016 at 05:34:31AM -0600, Jan Beulich wrote: > On 20.08.16 at 00:43, wrote: >>> Create generic alloc and copy functions. We need >>> separate tools for memory allocation and copy to >>> provide multiboot2

Re: [Xen-devel] [PATCH v5 06/16] x86/boot/reloc: create generic alloc and copy functions

2016-09-01 Thread Jan Beulich
>>> On 31.08.16 at 21:39, wrote: > I understood that you need reloc.c after this patch but it looks > that I was wrong. So, here it is after applying whole series. Thanks. Here are my notes: All callers of alloc_mem() cast the result to a pointer. While most of them

Re: [Xen-devel] [PATCH v5 06/16] x86/boot/reloc: create generic alloc and copy functions

2016-08-31 Thread Daniel Kiper
On Wed, Aug 31, 2016 at 09:25:57AM -0600, Jan Beulich wrote: > >>> On 31.08.16 at 17:13, wrote: > > On Tue, Aug 30, 2016 at 09:12:45AM -0600, Jan Beulich wrote: > >> >>> On 30.08.16 at 16:32, wrote: > >> > On Thu, Aug 25, 2016 at 05:34:31AM

Re: [Xen-devel] [PATCH v5 06/16] x86/boot/reloc: create generic alloc and copy functions

2016-08-31 Thread Jan Beulich
>>> On 31.08.16 at 17:13, wrote: > On Tue, Aug 30, 2016 at 09:12:45AM -0600, Jan Beulich wrote: >> >>> On 30.08.16 at 16:32, wrote: >> > On Thu, Aug 25, 2016 at 05:34:31AM -0600, Jan Beulich wrote: >> >> >>> On 20.08.16 at 00:43,

Re: [Xen-devel] [PATCH v5 06/16] x86/boot/reloc: create generic alloc and copy functions

2016-08-31 Thread Daniel Kiper
On Tue, Aug 30, 2016 at 09:12:45AM -0600, Jan Beulich wrote: > >>> On 30.08.16 at 16:32, wrote: > > On Thu, Aug 25, 2016 at 05:34:31AM -0600, Jan Beulich wrote: > >> >>> On 20.08.16 at 00:43, wrote: > >> > Create generic alloc and copy functions.

Re: [Xen-devel] [PATCH v5 06/16] x86/boot/reloc: create generic alloc and copy functions

2016-08-30 Thread Jan Beulich
>>> On 30.08.16 at 16:32, wrote: > On Thu, Aug 25, 2016 at 05:34:31AM -0600, Jan Beulich wrote: >> >>> On 20.08.16 at 00:43, wrote: >> > Create generic alloc and copy functions. We need >> > separate tools for memory allocation and copy to >> >

Re: [Xen-devel] [PATCH v5 06/16] x86/boot/reloc: create generic alloc and copy functions

2016-08-30 Thread Daniel Kiper
On Thu, Aug 25, 2016 at 05:34:31AM -0600, Jan Beulich wrote: > >>> On 20.08.16 at 00:43, wrote: > > Create generic alloc and copy functions. We need > > separate tools for memory allocation and copy to > > provide multiboot2 protocol support. > > > > Signed-off-by: Daniel

Re: [Xen-devel] [PATCH v5 06/16] x86/boot/reloc: create generic alloc and copy functions

2016-08-25 Thread Jan Beulich
>>> On 20.08.16 at 00:43, wrote: > Create generic alloc and copy functions. We need > separate tools for memory allocation and copy to > provide multiboot2 protocol support. > > Signed-off-by: Daniel Kiper The amount of casting in this patch

[Xen-devel] [PATCH v5 06/16] x86/boot/reloc: create generic alloc and copy functions

2016-08-19 Thread Daniel Kiper
Create generic alloc and copy functions. We need separate tools for memory allocation and copy to provide multiboot2 protocol support. Signed-off-by: Daniel Kiper --- v4 - suggestions/fixes: - avoid assembly usage. v3 - suggestions/fixes: - use "g" constraint