Re: [Xen-devel] [PATCH v5 16/16] livepatch: arm[32, 64], x86: NOP test-case

2016-09-23 Thread Julien Grall
Hi Konrad, On 23/09/16 02:35, Konrad Rzeszutek Wilk wrote: diff --git a/xen/test/livepatch/xen_nop.c b/xen/test/livepatch/xen_nop.c new file mode 100644 index 000..69dcbca --- /dev/null +++ b/xen/test/livepatch/xen_nop.c @@ -0,0 +1,48 @@ +/* + * Copyright (c) 2016 Oracle and/or its

Re: [Xen-devel] [PATCH v5 16/16] livepatch: arm[32, 64], x86: NOP test-case

2016-09-22 Thread Konrad Rzeszutek Wilk
.snip.. > > While on ARM32 there are 24 bytes: > > > > e52db004push{fp} > > e28db000add fp, sp, #0 <- NOP > > e3a8mov r0, #8 <- NOP > > e24bd000sub sp, fp, #0 <- NOP > > e49db004pop {fp} > > e12fff1ebx lr

Re: [Xen-devel] [PATCH v5 16/16] livepatch: arm[32, 64], x86: NOP test-case

2016-09-22 Thread Julien Grall
Hi Konrad, On 21/09/16 18:32, Konrad Rzeszutek Wilk wrote: The test-case is quite simple - we NOP the 'xen_minor_version'. The amount of NOPs depends on the architecture. On x86 the function is 11 bytes long: 55 push %rbp <- NOP 48 89 e5mov

[Xen-devel] [PATCH v5 16/16] livepatch: arm[32, 64], x86: NOP test-case

2016-09-21 Thread Konrad Rzeszutek Wilk
The test-case is quite simple - we NOP the 'xen_minor_version'. The amount of NOPs depends on the architecture. On x86 the function is 11 bytes long: 55 push %rbp <- NOP 48 89 e5mov%rsp,%rbp <- NOP b8 04 00 00 00 mov$0x4,%eax