Re: [Xen-devel] [PATCH v5 2/2] x86/hvm/viridian: Enable APIC assist enlightenment

2016-03-19 Thread Jan Beulich
>>> On 18.03.16 at 11:06, wrote: >> From: Jan Beulich [mailto:jbeul...@suse.com] >> Sent: 17 March 2016 16:43 >> >>> On 17.03.16 at 13:13, wrote: >> > @@ -1170,10 +1183,27 @@ int vlapic_has_pending_irq(struct vcpu *v) >> > !nestedhvm_vcpu_in_guestmode(v) ) >> > return irr; >> >

Re: [Xen-devel] [PATCH v5 2/2] x86/hvm/viridian: Enable APIC assist enlightenment

2016-03-19 Thread Jan Beulich
>>> On 17.03.16 at 13:13, wrote: > @@ -262,6 +258,59 @@ static void initialize_apic_assist(struct vcpu *v) > page ? page_to_mfn(page) : INVALID_MFN); > } > > +static uint32_t *get_apic_assist_word(struct vcpu *v) > +{ > +if ( !(viridian_feature_mask(v->domain) & HVMPV_apic_ass

[Xen-devel] [PATCH v5 2/2] x86/hvm/viridian: Enable APIC assist enlightenment

2016-03-19 Thread Paul Durrant
This patch adds code to enable the APIC assist enlightenment which, under certain conditions, means that the guest can avoid an EOI of the local APIC and thereby avoid a VMEXIT. Use of the enlightenment by the hypervisor is under control of the toolstack, and is added to the default set. Signed-o

Re: [Xen-devel] [PATCH v5 2/2] x86/hvm/viridian: Enable APIC assist enlightenment

2016-03-19 Thread Paul Durrant
> -Original Message- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: 17 March 2016 16:43 > To: Paul Durrant > Cc: Andrew Cooper; Wei Liu; Ian Jackson; Stefano Stabellini; xen- > de...@lists.xenproject.org; Keir (Xen.org) > Subject: Re: [PATCH v5 2/2] x86/hvm/viridian: Enable APIC ass

Re: [Xen-devel] [PATCH v5 2/2] x86/hvm/viridian: Enable APIC assist enlightenment

2016-03-19 Thread Paul Durrant
> -Original Message- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: 18 March 2016 10:25 > To: Paul Durrant > Cc: Andrew Cooper; Ian Jackson; Stefano Stabellini; Wei Liu; xen- > de...@lists.xenproject.org; Keir (Xen.org) > Subject: RE: [PATCH v5 2/2] x86/hvm/viridian: Enable APIC ass

Re: [Xen-devel] [PATCH v5 2/2] x86/hvm/viridian: Enable APIC assist enlightenment

2016-03-18 Thread Ian Jackson
> > > OK, sorry, emacs keeps moving them back. > > > > That's very unfriendly of it. > > Indeed. I think this could be fixed by adjusting the parameters provided at the bottom of each file in an Emacs `Local variables' block. See the variable help for c-file-offsets and c-offsets-alist. I thin