Re: [Xen-devel] [PATCH v5 3/5] libxl: add support for vscsi

2015-05-15 Thread Juergen Gross
On 05/15/2015 10:47 AM, Ian Campbell wrote: On Fri, 2015-05-15 at 07:58 +0200, Olaf Hering wrote: On Fri, May 15, Jürgen Groß wrote: Multi-LUN devices do exist and they are required to be presented as those to the guest. Ok, this means we need the bus concept. I will see if the API for

Re: [Xen-devel] [PATCH v5 3/5] libxl: add support for vscsi

2015-05-15 Thread Ian Campbell
On Fri, 2015-05-15 at 11:35 +0200, Juergen Gross wrote: On 05/15/2015 10:47 AM, Ian Campbell wrote: On Fri, 2015-05-15 at 07:58 +0200, Olaf Hering wrote: On Fri, May 15, Jürgen Groß wrote: Multi-LUN devices do exist and they are required to be presented as those to the guest. Ok,

Re: [Xen-devel] [PATCH v5 3/5] libxl: add support for vscsi

2015-05-15 Thread Olaf Hering
On Fri, May 15, Jürgen Groß wrote: Multi-LUN devices do exist and they are required to be presented as those to the guest. Ok, this means we need the bus concept. I will see if the API for add/remove can be changed that only devices get passed to the libxl. Olaf

Re: [Xen-devel] [PATCH v5 3/5] libxl: add support for vscsi

2015-05-15 Thread Olaf Hering
On Wed, May 13, Ian Campbell wrote: On Wed, 2015-05-06 at 13:28 +, Olaf Hering wrote: +++ b/docs/man/xl.pod.1 @@ -1328,6 +1328,24 @@ List virtual trusted platform modules for a domain. =back +=head2 PVSCSI DEVICES + +=over 4 + +=item Bscsi-attach Idomain-id Ipdev

Re: [Xen-devel] [PATCH v5 3/5] libxl: add support for vscsi

2015-05-15 Thread Ian Campbell
On Fri, 2015-05-15 at 10:46 +0100, Ian Campbell wrote: I'd like to start with seeing an expanded version of the comment in libxl.h which begins: /* * Devices * === which covers this new style API alongside the existing one and sets out the expected pattern of naming (both struct

Re: [Xen-devel] [PATCH v5 3/5] libxl: add support for vscsi

2015-05-14 Thread Jürgen Groß
On 05/13/2015 07:31 PM, Olaf Hering wrote: On Wed, May 13, Ian Campbell wrote: Is it important/useful that the user be able to configure/control the number (and addresses) of the buses themselves and which devices are on which, or can we get away with the pvpci model where the libxl user just

Re: [Xen-devel] [PATCH v5 3/5] libxl: add support for vscsi

2015-05-13 Thread Ian Campbell
Just looking at the API functions on this pass. General comment though: Please go through and rewrap any lines longer than 75-80, I saw quite a few as I was scrolling. @@ -3628,6 +3643,7 @@ static inline void libxl__update_config_vtpm(libxl__gc *gc, * devices have same identifier. */

Re: [Xen-devel] [PATCH v5 3/5] libxl: add support for vscsi

2015-05-13 Thread Ian Campbell
On Wed, 2015-05-06 at 13:28 +, Olaf Hering wrote: Port pvscsi support from xend to libxl: vscsi=['pdev,vdev{,options}'] xl scsi-attach xl scsi-detach xl scsi-list Signed-off-by: Olaf Hering o...@aepfle.de Cc: Ian Jackson ian.jack...@eu.citrix.com Cc: Stefano Stabellini

Re: [Xen-devel] [PATCH v5 3/5] libxl: add support for vscsi

2015-05-13 Thread Ian Campbell
On Wed, 2015-05-13 at 15:44 +0100, Ian Campbell wrote: #define COMPARE_PCI(a, b) ((a)-func == (b)-func \ (a)-bus == (b)-bus \ (a)-dev == (b)-dev) libxl_vscsi_dev = Struct(vscsi_dev, [ +(vscsi_dev_id, libxl_devid),

Re: [Xen-devel] [PATCH v5 3/5] libxl: add support for vscsi

2015-05-13 Thread Olaf Hering
On Wed, May 13, Ian Campbell wrote: You've represented this as a libxl_vscsi_dev which is actually a bus containing an array of devices, which leads to an API where to remove a device you have to provide libxl_device_scsi_remove with a libxl_device_vscsi where the individual devices are

Re: [Xen-devel] [PATCH v5 3/5] libxl: add support for vscsi

2015-05-13 Thread Olaf Hering
On Wed, May 13, Ian Campbell wrote: Just looking at the API functions on this pass. @@ -3628,6 +3643,7 @@ static inline void libxl__update_config_vtpm(libxl__gc *gc, * devices have same identifier. */ #define COMPARE_DEVID(a, b) ((a)-devid == (b)-devid) #define COMPARE_DISK(a, b)

Re: [Xen-devel] [PATCH v5 3/5] libxl: add support for vscsi

2015-05-13 Thread George Dunlap
On Wed, May 13, 2015 at 4:12 PM, Ian Campbell ian.campb...@citrix.com wrote: If that is not an option then we may need to follow the pvusb model (Chunyan and George CC-d in case I've got it wrong) which is to have explicit/separate host and device structs in the libxl API and associated

[Xen-devel] [PATCH v5 3/5] libxl: add support for vscsi

2015-05-06 Thread Olaf Hering
Port pvscsi support from xend to libxl: vscsi=['pdev,vdev{,options}'] xl scsi-attach xl scsi-detach xl scsi-list Signed-off-by: Olaf Hering o...@aepfle.de Cc: Ian Jackson ian.jack...@eu.citrix.com Cc: Stefano Stabellini stefano.stabell...@eu.citrix.com Cc: Ian Campbell