Re: [Xen-devel] [PATCH v5 5/6] xen/arm: vgic: Introduce helpers to extract/update/clear/set vGIC register ...

2015-11-16 Thread Ian Campbell
On Wed, 2015-11-11 at 16:09 +, Julien Grall wrote: > > I will either resend this whole series or only this patch depending on > the reviews. I don't think I've got anything to add to my existing acks or Stefano's comments. Best resend I think. Ian. _

Re: [Xen-devel] [PATCH v5 5/6] xen/arm: vgic: Introduce helpers to extract/update/clear/set vGIC register ...

2015-11-11 Thread Julien Grall
Hi, I've just noticed one error in this patch :/ On 09/11/15 15:49, Julien Grall wrote: > @@ -482,16 +500,16 @@ static int __vgic_v3_distr_common_mmio_write(const char > *name, struct vcpu *v, > return 0; > > case GICD_IPRIORITYR ... GICD_IPRIORITYRN: > +{ > +uint32_t

[Xen-devel] [PATCH v5 5/6] xen/arm: vgic: Introduce helpers to extract/update/clear/set vGIC register ...

2015-11-09 Thread Julien Grall
and use them in the vGIC emulation. The GIC registers may support different access sizes. Rather than open coding the access for every registers, provide a set of helpers to access them. The caller will have to call vgic_regN_* where N is the size of the emulated registers. The new helpers suppo