Re: [Xen-devel] [PATCH v5 9/9] xen/pciback: Implement PCI reset slot or bus with 'do_flr' SysFS attribute

2014-12-08 Thread Konrad Rzeszutek Wilk
On Mon, Dec 08, 2014 at 10:38:09AM +, David Vrabel wrote: > On 05/12/14 17:22, Konrad Rzeszutek Wilk wrote: > > On Fri, Dec 05, 2014 at 10:30:01AM +, David Vrabel wrote: > >> On 04/12/14 15:39, Alex Williamson wrote: > >>> > >>> I don't know what workaround you're talking about. As devices

Re: [Xen-devel] [PATCH v5 9/9] xen/pciback: Implement PCI reset slot or bus with 'do_flr' SysFS attribute

2014-12-08 Thread David Vrabel
On 05/12/14 17:22, Konrad Rzeszutek Wilk wrote: > On Fri, Dec 05, 2014 at 10:30:01AM +, David Vrabel wrote: >> On 04/12/14 15:39, Alex Williamson wrote: >>> >>> I don't know what workaround you're talking about. As devices are >>> released from the user, vfio-pci attempts to reset them. If >>

Re: [Xen-devel] [PATCH v5 9/9] xen/pciback: Implement PCI reset slot or bus with 'do_flr' SysFS attribute

2014-12-05 Thread Konrad Rzeszutek Wilk
On Fri, Dec 05, 2014 at 10:30:01AM +, David Vrabel wrote: > On 04/12/14 15:39, Alex Williamson wrote: > > > > I don't know what workaround you're talking about. As devices are > > released from the user, vfio-pci attempts to reset them. If > > pci_reset_function() returns success we mark the

Re: [Xen-devel] [PATCH v5 9/9] xen/pciback: Implement PCI reset slot or bus with 'do_flr' SysFS attribute

2014-12-05 Thread David Vrabel
On 04/12/14 15:39, Alex Williamson wrote: > > I don't know what workaround you're talking about. As devices are > released from the user, vfio-pci attempts to reset them. If > pci_reset_function() returns success we mark the device clean, otherwise > it gets marked dirty. Each time a device is

Re: [Xen-devel] [PATCH v5 9/9] xen/pciback: Implement PCI reset slot or bus with 'do_flr' SysFS attribute

2014-12-04 Thread Konrad Rzeszutek Wilk
On Thu, Dec 04, 2014 at 02:31:11PM +, David Vrabel wrote: > On 04/12/14 14:09, Sander Eikelenboom wrote: > > > > Thursday, December 4, 2014, 2:43:06 PM, you wrote: > > > >> On 04/12/14 13:10, Sander Eikelenboom wrote: > >>> > >>> Thursday, December 4, 2014, 1:24:47 PM, you wrote: > >>> >

Re: [Xen-devel] [PATCH v5 9/9] xen/pciback: Implement PCI reset slot or bus with 'do_flr' SysFS attribute

2014-12-04 Thread Alex Williamson
On Thu, 2014-12-04 at 17:25 +0100, Sander Eikelenboom wrote: > Thursday, December 4, 2014, 4:39:06 PM, you wrote: > > > On Thu, 2014-12-04 at 15:50 +0100, Sander Eikelenboom wrote: > >> Thursday, December 4, 2014, 3:31:11 PM, you wrote: > >> > >> > On 04/12/14 14:09, Sander Eikelenboom wrote: > >

Re: [Xen-devel] [PATCH v5 9/9] xen/pciback: Implement PCI reset slot or bus with 'do_flr' SysFS attribute

2014-12-04 Thread Sander Eikelenboom
Thursday, December 4, 2014, 4:39:06 PM, you wrote: > On Thu, 2014-12-04 at 15:50 +0100, Sander Eikelenboom wrote: >> Thursday, December 4, 2014, 3:31:11 PM, you wrote: >> >> > On 04/12/14 14:09, Sander Eikelenboom wrote: >> >> >> >> Thursday, December 4, 2014, 2:43:06 PM, you wrote: >> >> >> >

Re: [Xen-devel] [PATCH v5 9/9] xen/pciback: Implement PCI reset slot or bus with 'do_flr' SysFS attribute

2014-12-04 Thread Alex Williamson
On Thu, 2014-12-04 at 15:50 +0100, Sander Eikelenboom wrote: > Thursday, December 4, 2014, 3:31:11 PM, you wrote: > > > On 04/12/14 14:09, Sander Eikelenboom wrote: > >> > >> Thursday, December 4, 2014, 2:43:06 PM, you wrote: > >> > >>> On 04/12/14 13:10, Sander Eikelenboom wrote: > >

Re: [Xen-devel] [PATCH v5 9/9] xen/pciback: Implement PCI reset slot or bus with 'do_flr' SysFS attribute

2014-12-04 Thread Sander Eikelenboom
Thursday, December 4, 2014, 3:31:11 PM, you wrote: > On 04/12/14 14:09, Sander Eikelenboom wrote: >> >> Thursday, December 4, 2014, 2:43:06 PM, you wrote: >> >>> On 04/12/14 13:10, Sander Eikelenboom wrote: Thursday, December 4, 2014, 1:24:47 PM, you wrote: > On 04/12/14 12:0

Re: [Xen-devel] [PATCH v5 9/9] xen/pciback: Implement PCI reset slot or bus with 'do_flr' SysFS attribute

2014-12-04 Thread David Vrabel
On 04/12/14 14:09, Sander Eikelenboom wrote: > > Thursday, December 4, 2014, 2:43:06 PM, you wrote: > >> On 04/12/14 13:10, Sander Eikelenboom wrote: >>> >>> Thursday, December 4, 2014, 1:24:47 PM, you wrote: >>> On 04/12/14 12:06, Konrad Rzeszutek Wilk wrote: > > On Dec 4, 2014 6:30

Re: [Xen-devel] [PATCH v5 9/9] xen/pciback: Implement PCI reset slot or bus with 'do_flr' SysFS attribute

2014-12-04 Thread Sander Eikelenboom
Hello Sander, Thursday, December 4, 2014, 3:09:09 PM, you wrote: > Thursday, December 4, 2014, 2:43:06 PM, you wrote: >> On 04/12/14 13:10, Sander Eikelenboom wrote: >>> >>> Thursday, December 4, 2014, 1:24:47 PM, you wrote: >>> On 04/12/14 12:06, Konrad Rzeszutek Wilk wrote: > >

Re: [Xen-devel] [PATCH v5 9/9] xen/pciback: Implement PCI reset slot or bus with 'do_flr' SysFS attribute

2014-12-04 Thread Sander Eikelenboom
Thursday, December 4, 2014, 2:43:06 PM, you wrote: > On 04/12/14 13:10, Sander Eikelenboom wrote: >> >> Thursday, December 4, 2014, 1:24:47 PM, you wrote: >> >>> On 04/12/14 12:06, Konrad Rzeszutek Wilk wrote: On Dec 4, 2014 6:30 AM, David Vrabel wrote: > > On 03/12/14 21:40,

Re: [Xen-devel] [PATCH v5 9/9] xen/pciback: Implement PCI reset slot or bus with 'do_flr' SysFS attribute

2014-12-04 Thread David Vrabel
On 04/12/14 13:10, Sander Eikelenboom wrote: > > Thursday, December 4, 2014, 1:24:47 PM, you wrote: > >> On 04/12/14 12:06, Konrad Rzeszutek Wilk wrote: >>> >>> On Dec 4, 2014 6:30 AM, David Vrabel wrote: On 03/12/14 21:40, Konrad Rzeszutek Wilk wrote: > > Instead of doing all

Re: [Xen-devel] [PATCH v5 9/9] xen/pciback: Implement PCI reset slot or bus with 'do_flr' SysFS attribute

2014-12-04 Thread Sander Eikelenboom
Thursday, December 4, 2014, 1:24:47 PM, you wrote: > On 04/12/14 12:06, Konrad Rzeszutek Wilk wrote: >> >> On Dec 4, 2014 6:30 AM, David Vrabel wrote: >>> >>> On 03/12/14 21:40, Konrad Rzeszutek Wilk wrote: Instead of doing all this complex dance, we depend on the toolstack doi

Re: [Xen-devel] [PATCH v5 9/9] xen/pciback: Implement PCI reset slot or bus with 'do_flr' SysFS attribute

2014-12-04 Thread David Vrabel
On 04/12/14 12:06, Konrad Rzeszutek Wilk wrote: > > On Dec 4, 2014 6:30 AM, David Vrabel wrote: >> >> On 03/12/14 21:40, Konrad Rzeszutek Wilk wrote: >>> >>> Instead of doing all this complex dance, we depend on the toolstack >>> doing the right thing. As such implement the 'do_flr' SysFS attri

Re: [Xen-devel] [PATCH v5 9/9] xen/pciback: Implement PCI reset slot or bus with 'do_flr' SysFS attribute

2014-12-04 Thread Konrad Rzeszutek Wilk
On Dec 4, 2014 6:30 AM, David Vrabel wrote: > > On 03/12/14 21:40, Konrad Rzeszutek Wilk wrote: > > > > Instead of doing all this complex dance, we depend on the toolstack > > doing the right thing. As such implement the 'do_flr' SysFS attribute > > which 'xl' uses when a device is detached o

Re: [Xen-devel] [PATCH v5 9/9] xen/pciback: Implement PCI reset slot or bus with 'do_flr' SysFS attribute

2014-12-04 Thread David Vrabel
On 03/12/14 21:40, Konrad Rzeszutek Wilk wrote: > > Instead of doing all this complex dance, we depend on the toolstack > doing the right thing. As such implement the 'do_flr' SysFS attribute > which 'xl' uses when a device is detached or attached from/to a guest. > It bypasses the need to worry a

[Xen-devel] [PATCH v5 9/9] xen/pciback: Implement PCI reset slot or bus with 'do_flr' SysFS attribute

2014-12-03 Thread Konrad Rzeszutek Wilk
The life-cycle of a PCI device in Xen pciback is complex and is constrained by the PCI generic locking mechanism. It starts with the device being binded to us - for which we do a device function reset (and done via SysFS so the PCI lock is held) If the device is unbinded from us - we also do a fu