Re: [Xen-devel] [PATCH v5 for Xen 4.7 3/4] libxl: enable per-VCPU parameter settings for RTDS scheduler

On Tue, 2016-02-09 at 10:19 +, Wei Liu wrote: > On Mon, Feb 08, 2016 at 04:59:46PM -0600, Chong Li wrote: > >  > > I see. I'll think about re-designing the data structure of > > libxl_vcpu_sched_params. > > > > Or you can come up with a new API (function) that sets parameter for > all >

Re: [Xen-devel] [PATCH v5 for Xen 4.7 3/4] libxl: enable per-VCPU parameter settings for RTDS scheduler

On Mon, Feb 08, 2016 at 04:59:46PM -0600, Chong Li wrote: > On Mon, Feb 8, 2016 at 5:07 AM, Wei Liu wrote: > > > > > > [...] > > > >> +num_vcpus = max_vcpuid + 1; > > > >> +GCNEW_ARRAY(vcpus, num_vcpus); > > > >> +if (sched_rtds_validate_params(gc,

Re: [Xen-devel] [PATCH v5 for Xen 4.7 3/4] libxl: enable per-VCPU parameter settings for RTDS scheduler

On Thu, 2016-02-04 at 16:50 -0600, Chong Li wrote: >  > +static int sched_rtds_vcpu_set(libxl__gc *gc, uint32_t domid, > +   const libxl_vcpu_sched_params > *scinfo) > I'd call this sched_rtds_vcpus_params_set(). I know, it's longer, which is bad, but it's a lot more

Re: [Xen-devel] [PATCH v5 for Xen 4.7 3/4] libxl: enable per-VCPU parameter settings for RTDS scheduler

On Tue, Feb 9, 2016 at 6:00 AM, Dario Faggioli wrote: > On Thu, 2016-02-04 at 16:50 -0600, Chong Li wrote: >> >> +{ >> +int rc; >> +int i; >> +uint16_t max_vcpuid; >> +xc_dominfo_t info; >> +struct xen_domctl_schedparam_vcpu *vcpus; >> +uint32_t

Re: [Xen-devel] [PATCH v5 for Xen 4.7 3/4] libxl: enable per-VCPU parameter settings for RTDS scheduler

On Tue, Feb 09, 2016 at 01:00:37PM +0100, Dario Faggioli wrote: [...] > So, it looks to me that this function can be split in two. One would be > the actual sched_rtds_vcpus_params_set(), and it will do what is being > done above here. > > The other one would be something like >

Re: [Xen-devel] [PATCH v5 for Xen 4.7 3/4] libxl: enable per-VCPU parameter settings for RTDS scheduler

On Fri, Feb 05, 2016 at 06:10:33PM -0600, Chong Li wrote: > I'll fix these coding style issues. > Thank you. :-) [...] > >> +num_vcpus = max_vcpuid + 1; > >> +GCNEW_ARRAY(vcpus, num_vcpus); > >> +if (sched_rtds_validate_params(gc, scinfo->vcpus[0].period, > >> +

Re: [Xen-devel] [PATCH v5 for Xen 4.7 3/4] libxl: enable per-VCPU parameter settings for RTDS scheduler

On Mon, Feb 8, 2016 at 5:07 AM, Wei Liu wrote: > > > [...] > > >> +num_vcpus = max_vcpuid + 1; > > >> +GCNEW_ARRAY(vcpus, num_vcpus); > > >> +if (sched_rtds_validate_params(gc, scinfo->vcpus[0].period, > > >> +

Re: [Xen-devel] [PATCH v5 for Xen 4.7 3/4] libxl: enable per-VCPU parameter settings for RTDS scheduler

On Fri, Feb 05, 2016 at 04:59:43PM +0100, Dario Faggioli wrote: > On Fri, 2016-02-05 at 14:44 +, Wei Liu wrote: > > On Thu, Feb 04, 2016 at 04:50:43PM -0600, Chong Li wrote: > > > Add libxl_vcpu_sched_params_get/set and sched_rtds_vcpu_get/set > > > functions to support per-VCPU settings. > >

Re: [Xen-devel] [PATCH v5 for Xen 4.7 3/4] libxl: enable per-VCPU parameter settings for RTDS scheduler

On Fri, 2016-02-05 at 14:44 +, Wei Liu wrote: > On Thu, Feb 04, 2016 at 04:50:43PM -0600, Chong Li wrote: > > Add libxl_vcpu_sched_params_get/set and sched_rtds_vcpu_get/set > > functions to support per-VCPU settings. > > > > I will need Dario or George to review the logic of the code. >

Re: [Xen-devel] [PATCH v5 for Xen 4.7 3/4] libxl: enable per-VCPU parameter settings for RTDS scheduler

On Thu, Feb 04, 2016 at 04:50:43PM -0600, Chong Li wrote: > Add libxl_vcpu_sched_params_get/set and sched_rtds_vcpu_get/set > functions to support per-VCPU settings. > I will need Dario or George to review the logic of the code. If some of the comments below don't make sense, just ask. I'm sure

Re: [Xen-devel] [PATCH v5 for Xen 4.7 3/4] libxl: enable per-VCPU parameter settings for RTDS scheduler

I'll fix these coding style issues. On Fri, Feb 5, 2016 at 8:44 AM, Wei Liu wrote: > On Thu, Feb 04, 2016 at 04:50:43PM -0600, Chong Li wrote: >> Add libxl_vcpu_sched_params_get/set and sched_rtds_vcpu_get/set >> functions to support per-VCPU settings. >> > > I will need

[Xen-devel] [PATCH v5 for Xen 4.7 3/4] libxl: enable per-VCPU parameter settings for RTDS scheduler

Add libxl_vcpu_sched_params_get/set and sched_rtds_vcpu_get/set functions to support per-VCPU settings. Signed-off-by: Chong Li Signed-off-by: Meng Xu Signed-off-by: Sisu Xi --- Changes on PATCH v4: 1) Coding style changes Changes