[Xen-devel] [PATCH v6 20/23] libxlu: record line and column number when parsing values

2015-02-26 Thread Wei Liu
Originally only setting has line number recorded. Since we're moving to more sophisticated API, record line number and column number for individual value. They are useful for error reporting. Signed-off-by: Wei Liu Cc: Ian Campbell Cc: Ian Jackson --- tools/libxl/libxlu_cfg.c | 10 +++

Re: [Xen-devel] [PATCH v6 20/23] libxlu: record line and column number when parsing values

2015-03-06 Thread Ian Jackson
Wei Liu writes ("[PATCH v6 20/23] libxlu: record line and column number when parsing values"): > Originally only setting has line number recorded. Since we're moving to > more sophisticated API, record line number and column number for > individual value. They are useful for error reporting. This

Re: [Xen-devel] [PATCH v6 20/23] libxlu: record line and column number when parsing values

2015-03-06 Thread Wei Liu
On Fri, Mar 06, 2015 at 11:36:03AM +, Ian Jackson wrote: > Wei Liu writes ("[PATCH v6 20/23] libxlu: record line and column number when > parsing values"): > > Originally only setting has line number recorded. Since we're moving to > > more sophisticated API, record line number and column numb

Re: [Xen-devel] [PATCH v6 20/23] libxlu: record line and column number when parsing values

2015-03-06 Thread Ian Jackson
Wei Liu writes ("Re: [PATCH v6 20/23] libxlu: record line and column number when parsing values"): > Ack. This is how it looks like now. The changes are > > 1. Use YYLTYPE instead of line and column. This is better but why not have YYLTYPE inside XLU_ConfigValue ? > 2. Handle empty rule inside

Re: [Xen-devel] [PATCH v6 20/23] libxlu: record line and column number when parsing values

2015-03-06 Thread Wei Liu
On Fri, Mar 06, 2015 at 04:11:53PM +, Wei Liu wrote: > On Fri, Mar 06, 2015 at 02:30:27PM +, Ian Jackson wrote: > > Wei Liu writes ("Re: [PATCH v6 20/23] libxlu: record line and column number > > when parsing values"): > > > Ack. This is how it looks like now. The changes are > > > > > >

Re: [Xen-devel] [PATCH v6 20/23] libxlu: record line and column number when parsing values

2015-03-06 Thread Wei Liu
On Fri, Mar 06, 2015 at 02:30:27PM +, Ian Jackson wrote: > Wei Liu writes ("Re: [PATCH v6 20/23] libxlu: record line and column number > when parsing values"): > > Ack. This is how it looks like now. The changes are > > > > 1. Use YYLTYPE instead of line and column. > > This is better but wh