Re: [Xen-devel] [PATCH v6 24/31] xen/arm: ITS: Add GICR register emulation

2015-09-09 Thread Julien Grall
On 09/09/15 14:55, Ian Campbell wrote: >>> Based on the spec, those 2 checks are wrong and make impossible to use >>> LPIs. Please test this patch series before sending it on the ML. >> >> Why do you think so?. > > Consider which LPI is the subject of the word at the address pointed to by > GICR_P

Re: [Xen-devel] [PATCH v6 24/31] xen/arm: ITS: Add GICR register emulation

2015-09-09 Thread Ian Campbell
On Mon, 2015-09-07 at 20:56 +0530, Vijay Kilari wrote: > On Mon, Sep 7, 2015 at 7:50 PM, Julien Grall > wrote: > > Hi Vijay, > > > > On 31/08/15 12:06, vijay.kil...@gmail.com wrote: > > > +static int vgic_v3_gits_lpi_mmio_read(struct vcpu *v, mmio_info_t > > > *info) > > > > [...] > > > > > +

Re: [Xen-devel] [PATCH v6 24/31] xen/arm: ITS: Add GICR register emulation

2015-09-07 Thread Vijay Kilari
On Mon, Sep 7, 2015 at 7:50 PM, Julien Grall wrote: > Hi Vijay, > > On 31/08/15 12:06, vijay.kil...@gmail.com wrote: >> +static int vgic_v3_gits_lpi_mmio_read(struct vcpu *v, mmio_info_t *info) > > [...] > >> +/* Neglect if not LPI. */ >> +if ( offset < FIRST_GIC_LPI ) >> +{ >> +

Re: [Xen-devel] [PATCH v6 24/31] xen/arm: ITS: Add GICR register emulation

2015-09-07 Thread Julien Grall
Hi Vijay, On 31/08/15 12:06, vijay.kil...@gmail.com wrote: > +static int vgic_v3_gits_lpi_mmio_read(struct vcpu *v, mmio_info_t *info) [...] > +/* Neglect if not LPI. */ > +if ( offset < FIRST_GIC_LPI ) > +{ > +*r = 0; > +return 1; > +} [...] > +static int vgic_

[Xen-devel] [PATCH v6 24/31] xen/arm: ITS: Add GICR register emulation

2015-08-31 Thread vijay . kilari
From: Vijaya Kumar K Emulate LPI related changes to GICR registers Signed-off-by: Vijaya Kumar K --- v6: - Moved LPI handling code to vgic-v3.c - parse LPI property table on GICR_PROPBASER update - use vgic_is_lpi_supported() v5: - Handled all sizes access to LPI configuration table