Re: [Xen-devel] [PATCH v9 01/13] hvm: Move MAX_INST_LEN into x86_emulate.h

2015-03-03 Thread George Dunlap
On 02/16/2015 11:05 PM, Don Slutz wrote: Change some hard coded 15 into MAX_INST_LEN Signed-off-by: Don Slutz dsl...@verizon.com Since it looks like you'll be re-sending the series anyway, it might be nice to include No functional changes in the description, just to make it clear. -George

Re: [Xen-devel] [PATCH v9 01/13] hvm: Move MAX_INST_LEN into x86_emulate.h

2015-03-03 Thread Andrew Cooper
On 03/03/15 14:02, George Dunlap wrote: On 02/16/2015 11:05 PM, Don Slutz wrote: Change some hard coded 15 into MAX_INST_LEN Signed-off-by: Don Slutz dsl...@verizon.com Since it looks like you'll be re-sending the series anyway, it might be nice to include No functional changes in the

Re: [Xen-devel] [PATCH v9 01/13] hvm: Move MAX_INST_LEN into x86_emulate.h

2015-03-03 Thread George Dunlap
On 03/03/2015 02:08 PM, Andrew Cooper wrote: On 03/03/15 14:02, George Dunlap wrote: On 02/16/2015 11:05 PM, Don Slutz wrote: Change some hard coded 15 into MAX_INST_LEN Signed-off-by: Don Slutz dsl...@verizon.com Since it looks like you'll be re-sending the series anyway, it might be nice

Re: [Xen-devel] [PATCH v9 01/13] hvm: Move MAX_INST_LEN into x86_emulate.h

2015-02-17 Thread Don Slutz
On 02/17/15 04:52, Andrew Cooper wrote: On 16/02/15 23:05, Don Slutz wrote: Change some hard coded 15 into MAX_INST_LEN Signed-off-by: Don Slutz dsl...@verizon.com One formatting suggestion. --- ... diff --git a/xen/arch/x86/x86_emulate/x86_emulate.c

Re: [Xen-devel] [PATCH v9 01/13] hvm: Move MAX_INST_LEN into x86_emulate.h

2015-02-17 Thread Andrew Cooper
On 16/02/15 23:05, Don Slutz wrote: Change some hard coded 15 into MAX_INST_LEN Signed-off-by: Don Slutz dsl...@verizon.com One formatting suggestion. --- xen/arch/x86/hvm/svm/emulate.c | 2 -- xen/arch/x86/hvm/svm/svm.c | 4 ++-- xen/arch/x86/hvm/vmx/vmx.c

[Xen-devel] [PATCH v9 01/13] hvm: Move MAX_INST_LEN into x86_emulate.h

2015-02-16 Thread Don Slutz
Change some hard coded 15 into MAX_INST_LEN Signed-off-by: Don Slutz dsl...@verizon.com --- xen/arch/x86/hvm/svm/emulate.c | 2 -- xen/arch/x86/hvm/svm/svm.c | 4 ++-- xen/arch/x86/hvm/vmx/vmx.c | 2 +- xen/arch/x86/x86_emulate/x86_emulate.c | 4 ++--