Re: [Xen-devel] [PATCH v9 07/13] x86: add multiboot2 protocol support for EFI platforms

2016-11-30 Thread Daniel Kiper
On Wed, Nov 30, 2016 at 06:59:57AM -0700, Jan Beulich wrote: > >>> On 30.11.16 at 14:45, wrote: > > On Fri, Nov 25, 2016 at 12:50:55AM -0700, Jan Beulich wrote: > >> >>> On 24.11.16 at 22:44, wrote: > >> > On Thu, Nov 24, 2016 at 04:08:12AM

Re: [Xen-devel] [PATCH v9 07/13] x86: add multiboot2 protocol support for EFI platforms

2016-11-30 Thread Jan Beulich
>>> On 30.11.16 at 14:45, wrote: > On Fri, Nov 25, 2016 at 12:50:55AM -0700, Jan Beulich wrote: >> >>> On 24.11.16 at 22:44, wrote: >> > On Thu, Nov 24, 2016 at 04:08:12AM -0700, Jan Beulich wrote: >> >> >>> On 23.11.16 at 19:52,

Re: [Xen-devel] [PATCH v9 07/13] x86: add multiboot2 protocol support for EFI platforms

2016-11-30 Thread Daniel Kiper
On Fri, Nov 25, 2016 at 12:50:55AM -0700, Jan Beulich wrote: > >>> On 24.11.16 at 22:44, wrote: > > On Thu, Nov 24, 2016 at 04:08:12AM -0700, Jan Beulich wrote: > >> >>> On 23.11.16 at 19:52, wrote: > >> > On 29/09/16 22:42, Daniel Kiper wrote:

Re: [Xen-devel] [PATCH v9 07/13] x86: add multiboot2 protocol support for EFI platforms

2016-11-24 Thread Jan Beulich
>>> On 24.11.16 at 22:44, wrote: > On Thu, Nov 24, 2016 at 04:08:12AM -0700, Jan Beulich wrote: >> >>> On 23.11.16 at 19:52, wrote: >> > On 29/09/16 22:42, Daniel Kiper wrote: > > [...] > >> >> +.Lefi_mb2_tsize: >> >> +/* Check

Re: [Xen-devel] [PATCH v9 07/13] x86: add multiboot2 protocol support for EFI platforms

2016-11-24 Thread Daniel Kiper
On Thu, Nov 24, 2016 at 04:08:12AM -0700, Jan Beulich wrote: > >>> On 23.11.16 at 19:52, wrote: > > On 29/09/16 22:42, Daniel Kiper wrote: [...] > >> +.Lefi_mb2_tsize: > >> +/* Check Multiboot2 information total size. */ > >> +mov %ecx,%r8d > >> +

Re: [Xen-devel] [PATCH v9 07/13] x86: add multiboot2 protocol support for EFI platforms

2016-11-24 Thread Daniel Kiper
On Wed, Nov 23, 2016 at 06:52:27PM +, Andrew Cooper wrote: > On 29/09/16 22:42, Daniel Kiper wrote: [...] > > +vga_text_buffer: > > +.long 0xb8000 > > Why is this turned into a variable? We must disable VGA accesses during runtime on platforms which does not have one like e.g.

Re: [Xen-devel] [PATCH v9 07/13] x86: add multiboot2 protocol support for EFI platforms

2016-11-24 Thread Jan Beulich
>>> On 23.11.16 at 19:52, wrote: > On 29/09/16 22:42, Daniel Kiper wrote: >> @@ -100,20 +107,49 @@ multiboot2_header_start: >> gdt_boot_descr: >> .word 6*8-1 >> .long sym_phys(trampoline_gdt) >> +.long 0 /* Needed for 64-bit lgdt */ >> +

Re: [Xen-devel] [PATCH v9 07/13] x86: add multiboot2 protocol support for EFI platforms

2016-11-23 Thread Andrew Cooper
On 29/09/16 22:42, Daniel Kiper wrote: > This way Xen can be loaded on EFI platforms using GRUB2 and > other boot loaders which support multiboot2 protocol. > > Signed-off-by: Daniel Kiper > --- > v9 - suggestions/fixes: >- use .L labels instead of numeric ones in

[Xen-devel] [PATCH v9 07/13] x86: add multiboot2 protocol support for EFI platforms

2016-09-29 Thread Daniel Kiper
This way Xen can be loaded on EFI platforms using GRUB2 and other boot loaders which support multiboot2 protocol. Signed-off-by: Daniel Kiper --- v9 - suggestions/fixes: - use .L labels instead of numeric ones in multiboot2 data scanning loops (suggested by Jan