Re: [Xen-devel] [PATCHv1] x86: rtc_cmos platform device requires legacy irqs

2015-12-08 Thread Thomas Gleixner
On Fri, 4 Dec 2015, David Vrabel wrote: > On 04/12/15 14:06, David Vrabel wrote: > > On 03/12/15 10:43, David Vrabel wrote: > >> Adding the rtc platform device when there are no legacy irqs (no > >> legacy PIC) causes a conflict with other devices that end up using the > >> same irq number. > > >

Re: [Xen-devel] [PATCHv1] x86: rtc_cmos platform device requires legacy irqs

2015-12-08 Thread Boris Ostrovsky
On 12/08/2015 04:02 PM, Thomas Gleixner wrote: On Fri, 4 Dec 2015, David Vrabel wrote: On 04/12/15 14:06, David Vrabel wrote: On 03/12/15 10:43, David Vrabel wrote: Adding the rtc platform device when there are no legacy irqs (no legacy PIC) causes a conflict with other devices that end up

Re: [Xen-devel] [PATCHv1] x86: rtc_cmos platform device requires legacy irqs

2015-12-08 Thread Thomas Gleixner
On Tue, 8 Dec 2015, Boris Ostrovsky wrote: > On 12/08/2015 04:02 PM, Thomas Gleixner wrote: > > > > --- a/arch/x86/kernel/rtc.c > > > > +++ b/arch/x86/kernel/rtc.c > > > > @@ -200,6 +200,9 @@ static __init int add_rtc_cmos(void) > > > > } > > > > #endif > > > > + if

Re: [Xen-devel] [PATCHv1] x86: rtc_cmos platform device requires legacy irqs

2015-12-04 Thread Boris Ostrovsky
On 12/04/2015 10:24 AM, David Vrabel wrote: On 04/12/15 14:06, David Vrabel wrote: On 03/12/15 10:43, David Vrabel wrote: Adding the rtc platform device when there are no legacy irqs (no legacy PIC) causes a conflict with other devices that end up using the same irq number. An alternative

Re: [Xen-devel] [PATCHv1] x86: rtc_cmos platform device requires legacy irqs

2015-12-04 Thread David Vrabel
On 04/12/15 14:06, David Vrabel wrote: > On 03/12/15 10:43, David Vrabel wrote: >> Adding the rtc platform device when there are no legacy irqs (no >> legacy PIC) causes a conflict with other devices that end up using the >> same irq number. > > An alternative is to remove the rtc_cmos platform

Re: [Xen-devel] [PATCHv1] x86: rtc_cmos platform device requires legacy irqs

2015-12-04 Thread Vitaly Kuznetsov
Boris Ostrovsky writes: > On 12/04/2015 10:24 AM, David Vrabel wrote: >> On 04/12/15 14:06, David Vrabel wrote: >>> On 03/12/15 10:43, David Vrabel wrote: Adding the rtc platform device when there are no legacy irqs (no legacy PIC) causes a conflict with

Re: [Xen-devel] [PATCHv1] x86: rtc_cmos platform device requires legacy irqs

2015-12-04 Thread David Vrabel
On 03/12/15 10:43, David Vrabel wrote: > Adding the rtc platform device when there are no legacy irqs (no > legacy PIC) causes a conflict with other devices that end up using the > same irq number. An alternative is to remove the rtc_cmos platform device in Xen PV guests. Any preference on how

Re: [Xen-devel] [PATCHv1] x86: rtc_cmos platform device requires legacy irqs

2015-12-04 Thread Boris Ostrovsky
On 12/04/2015 10:52 AM, Vitaly Kuznetsov wrote: Boris Ostrovsky writes: On 12/04/2015 10:24 AM, David Vrabel wrote: On 04/12/15 14:06, David Vrabel wrote: On 03/12/15 10:43, David Vrabel wrote: Adding the rtc platform device when there are no legacy irqs (no

[Xen-devel] [PATCHv1] x86: rtc_cmos platform device requires legacy irqs

2015-12-03 Thread David Vrabel
Adding the rtc platform device when there are no legacy irqs (no legacy PIC) causes a conflict with other devices that end up using the same irq number. In a single VCPU Xen PV guest we should have: /proc/interrupts: CPU0 0: 4934 xen-percpu-virq timer0 1: 0

Re: [Xen-devel] [PATCHv1] x86: rtc_cmos platform device requires legacy irqs

2015-12-03 Thread Vitaly Kuznetsov
David Vrabel writes: > Adding the rtc platform device when there are no legacy irqs (no > legacy PIC) No PIC != No legacy IRQs, Hyper-V Gen2 represents such a platform (and it has RTC on irq8). I've tested this patch against it and it appears to work because the device

Re: [Xen-devel] [PATCHv1] x86: rtc_cmos platform device requires legacy irqs

2015-12-03 Thread David Vrabel
On 03/12/15 11:23, Vitaly Kuznetsov wrote: > David Vrabel writes: > >> Adding the rtc platform device when there are no legacy irqs (no >> legacy PIC) > > No PIC != No legacy IRQs, Hyper-V Gen2 represents such a platform (and > it has RTC on irq8). I've tested this