Re: [Xen-devel] [Qemu-devel] [PATCH] Do not emulate a floppy drive when -nodefaults

2015-05-18 Thread Kevin Wolf
Am 14.05.2015 um 19:54 hat John Snow geschrieben: > On 05/14/2015 10:07 AM, Michael S. Tsirkin wrote: > > On Thu, May 14, 2015 at 02:02:04PM +0200, Markus Armbruster wrote: > >> * Create the FDC only if the option is "on". > >> > >> * Optional: make -drive if=floppy,... auto-enable it > > > > Ever

Re: [Xen-devel] [Qemu-devel] [PATCH] Do not emulate a floppy drive when -nodefaults

2015-05-15 Thread Markus Armbruster
John Snow writes: > On 05/14/2015 10:07 AM, Michael S. Tsirkin wrote: >> On Thu, May 14, 2015 at 02:02:04PM +0200, Markus Armbruster wrote: >>> Correct. >>> >>> Here's how I think it should be done: >>> >>> * Create a machine option to control the FDC >>> >>> This is a machine-specific option.

Re: [Xen-devel] [Qemu-devel] [PATCH] Do not emulate a floppy drive when -nodefaults

2015-05-14 Thread John Snow
On 05/14/2015 10:07 AM, Michael S. Tsirkin wrote: > On Thu, May 14, 2015 at 02:02:04PM +0200, Markus Armbruster wrote: >> Correct. >> >> Here's how I think it should be done: >> >> * Create a machine option to control the FDC >> >> This is a machine-specific option. It should only exist for ma

Re: [Xen-devel] [Qemu-devel] [PATCH] Do not emulate a floppy drive when -nodefaults

2015-05-14 Thread Stefano Stabellini
On Thu, 14 May 2015, Paolo Bonzini wrote: > On 14/05/2015 16:39, Stefano Stabellini wrote: > > On Thu, 14 May 2015, Paolo Bonzini wrote: > >> On 14/05/2015 15:25, Sander Eikelenboom wrote: > >>> I tend to kindly disagree if you look at the broader perspective, yes > >>> it's could > >>> be a stor

Re: [Xen-devel] [Qemu-devel] [PATCH] Do not emulate a floppy drive when -nodefaults

2015-05-14 Thread Paolo Bonzini
On 14/05/2015 16:39, Stefano Stabellini wrote: > On Thu, 14 May 2015, Paolo Bonzini wrote: >> On 14/05/2015 15:25, Sander Eikelenboom wrote: >>> I tend to kindly disagree if you look at the broader perspective, yes it's >>> could >>> be a storm in a tea cup, but there seems to be a pattern. >>>

Re: [Xen-devel] [Qemu-devel] [PATCH] Do not emulate a floppy drive when -nodefaults

2015-05-14 Thread Stefano Stabellini
On Thu, 14 May 2015, Paolo Bonzini wrote: > On 14/05/2015 15:25, Sander Eikelenboom wrote: > > I tend to kindly disagree if you look at the broader perspective, yes it's > > could > > be a storm in a tea cup, but there seems to be a pattern. > > > > From a "cmdline user" / "platform emulation" p

Re: [Xen-devel] [Qemu-devel] [PATCH] Do not emulate a floppy drive when -nodefaults

2015-05-14 Thread Michael S. Tsirkin
On Thu, May 14, 2015 at 02:02:04PM +0200, Markus Armbruster wrote: > Correct. > > Here's how I think it should be done: > > * Create a machine option to control the FDC > > This is a machine-specific option. It should only exist for machine > types that have an optional FDC. > > Default

Re: [Xen-devel] [Qemu-devel] [PATCH] Do not emulate a floppy drive when -nodefaults

2015-05-14 Thread Michael S. Tsirkin
On Thu, May 14, 2015 at 03:25:39PM +0200, Sander Eikelenboom wrote: > > Thursday, May 14, 2015, 2:53:17 PM, you wrote: > > > > > On 14/05/2015 14:45, Markus Armbruster wrote: > >> Paolo Bonzini writes: > >> > >>> On 14/05/2015 14:02, Markus Armbruster wrote: > It should certainly be of

Re: [Xen-devel] [Qemu-devel] [PATCH] Do not emulate a floppy drive when -nodefaults

2015-05-14 Thread Paolo Bonzini
On 14/05/2015 15:25, Sander Eikelenboom wrote: > I tend to kindly disagree if you look at the broader perspective, yes it's > could > be a storm in a tea cup, but there seems to be a pattern. > > From a "cmdline user" / "platform emulation" point of view i can imagine that > some sort of > a

Re: [Xen-devel] [Qemu-devel] [PATCH] Do not emulate a floppy drive when -nodefaults

2015-05-14 Thread Markus Armbruster
Paolo Bonzini writes: > On 14/05/2015 13:47, Michael S. Tsirkin wrote: >> > I would be OK with a new property too, as we could set it from >> > libxl or libvirt. Anybody would be happy to pick this one up or should I >> > do it? >> >> Pls go ahead, I can merge it in the pc tree. > > Note that bec

Re: [Xen-devel] [Qemu-devel] [PATCH] Do not emulate a floppy drive when -nodefaults

2015-05-14 Thread Daniel P. Berrange
On Thu, May 14, 2015 at 02:45:30PM +0200, Markus Armbruster wrote: > Paolo Bonzini writes: > > > On 14/05/2015 14:02, Markus Armbruster wrote: > >> It should certainly be off for pc-q35-2.4 and newer. Real Q35 boards > >> commonly don't have an FDC (depends on the Super I/O chip used). > >>

Re: [Xen-devel] [Qemu-devel] [PATCH] Do not emulate a floppy drive when -nodefaults

2015-05-14 Thread Daniel P. Berrange
On Thu, May 14, 2015 at 03:25:39PM +0200, Sander Eikelenboom wrote: > > Thursday, May 14, 2015, 2:53:17 PM, you wrote: > > > > > On 14/05/2015 14:45, Markus Armbruster wrote: > >> Paolo Bonzini writes: > >> > >>> On 14/05/2015 14:02, Markus Armbruster wrote: > It should certainly be of

Re: [Xen-devel] [Qemu-devel] [PATCH] Do not emulate a floppy drive when -nodefaults

2015-05-14 Thread Sander Eikelenboom
Thursday, May 14, 2015, 2:53:17 PM, you wrote: > On 14/05/2015 14:45, Markus Armbruster wrote: >> Paolo Bonzini writes: >> >>> On 14/05/2015 14:02, Markus Armbruster wrote: It should certainly be off for pc-q35-2.4 and newer. Real Q35 boards commonly don't have an FDC (depends

Re: [Xen-devel] [Qemu-devel] [PATCH] Do not emulate a floppy drive when -nodefaults

2015-05-14 Thread Paolo Bonzini
On 14/05/2015 14:45, Markus Armbruster wrote: > Paolo Bonzini writes: > >> On 14/05/2015 14:02, Markus Armbruster wrote: >>> It should certainly be off for pc-q35-2.4 and newer. Real Q35 boards >>> commonly don't have an FDC (depends on the Super I/O chip used). >>> >>> We may want to ke

Re: [Xen-devel] [Qemu-devel] [PATCH] Do not emulate a floppy drive when -nodefaults

2015-05-14 Thread Markus Armbruster
Paolo Bonzini writes: > On 14/05/2015 14:02, Markus Armbruster wrote: >> It should certainly be off for pc-q35-2.4 and newer. Real Q35 boards >> commonly don't have an FDC (depends on the Super I/O chip used). >> >> We may want to keep it off for pc-i440fx-2.4 and newer. I doubt >> the

Re: [Xen-devel] [Qemu-devel] [PATCH] Do not emulate a floppy drive when -nodefaults

2015-05-14 Thread Paolo Bonzini
On 14/05/2015 14:02, Markus Armbruster wrote: > It should certainly be off for pc-q35-2.4 and newer. Real Q35 boards > commonly don't have an FDC (depends on the Super I/O chip used). > > We may want to keep it off for pc-i440fx-2.4 and newer. I doubt > there's a real i440FX without an

Re: [Xen-devel] [Qemu-devel] [PATCH] Do not emulate a floppy drive when -nodefaults

2015-05-14 Thread Markus Armbruster
"Daniel P. Berrange" writes: > On Thu, May 14, 2015 at 12:12:52PM +0100, Stefano Stabellini wrote: >> On Wed, 13 May 2015, John Snow wrote: >> > On 05/13/2015 02:15 PM, Stefano Stabellini wrote: >> > > On Wed, 13 May 2015, Daniel P. Berrange wrote: >> > >> On Wed, May 13, 2015 at 06:29:46PM +0100

Re: [Xen-devel] [Qemu-devel] [PATCH] Do not emulate a floppy drive when -nodefaults

2015-05-14 Thread Michael S. Tsirkin
On Thu, May 14, 2015 at 01:54:22PM +0200, Paolo Bonzini wrote: > > > On 14/05/2015 13:47, Michael S. Tsirkin wrote: > > > I would be OK with a new property too, as we could set it from > > > libxl or libvirt. Anybody would be happy to pick this one up or should I > > > do it? > > > > Pls go ahead

Re: [Xen-devel] [Qemu-devel] [PATCH] Do not emulate a floppy drive when -nodefaults

2015-05-14 Thread Paolo Bonzini
On 14/05/2015 13:47, Michael S. Tsirkin wrote: > > I would be OK with a new property too, as we could set it from > > libxl or libvirt. Anybody would be happy to pick this one up or should I > > do it? > > Pls go ahead, I can merge it in the pc tree. Note that because of the "-drive if=none,id=f

Re: [Xen-devel] [Qemu-devel] [PATCH] Do not emulate a floppy drive when -nodefaults

2015-05-14 Thread Michael S. Tsirkin
On Thu, May 14, 2015 at 12:12:52PM +0100, Stefano Stabellini wrote: > I would be OK with a new property too, as we could set it from > libxl or libvirt. Anybody would be happy to pick this one up or should I > do it? Pls go ahead, I can merge it in the pc tree. -- MST __

Re: [Xen-devel] [Qemu-devel] [PATCH] Do not emulate a floppy drive when -nodefaults

2015-05-14 Thread Michael S. Tsirkin
On Thu, May 14, 2015 at 12:18:26PM +0100, Daniel P. Berrange wrote: > On Thu, May 14, 2015 at 12:12:52PM +0100, Stefano Stabellini wrote: > > On Wed, 13 May 2015, John Snow wrote: > > > On 05/13/2015 02:15 PM, Stefano Stabellini wrote: > > > > On Wed, 13 May 2015, Daniel P. Berrange wrote: > > > >>

Re: [Xen-devel] [Qemu-devel] [PATCH] Do not emulate a floppy drive when -nodefaults

2015-05-14 Thread Daniel P. Berrange
On Thu, May 14, 2015 at 12:12:52PM +0100, Stefano Stabellini wrote: > On Wed, 13 May 2015, John Snow wrote: > > On 05/13/2015 02:15 PM, Stefano Stabellini wrote: > > > On Wed, 13 May 2015, Daniel P. Berrange wrote: > > >> On Wed, May 13, 2015 at 06:29:46PM +0100, Stefano Stabellini wrote: > > >>> D

Re: [Xen-devel] [Qemu-devel] [PATCH] Do not emulate a floppy drive when -nodefaults

2015-05-14 Thread Stefano Stabellini
On Wed, 13 May 2015, John Snow wrote: > On 05/13/2015 02:15 PM, Stefano Stabellini wrote: > > On Wed, 13 May 2015, Daniel P. Berrange wrote: > >> On Wed, May 13, 2015 at 06:29:46PM +0100, Stefano Stabellini wrote: > >>> Do not emulate a floppy drive if no drives are supposed to be present. > >>> >

Re: [Xen-devel] [Qemu-devel] [PATCH] Do not emulate a floppy drive when -nodefaults

2015-05-13 Thread Michael S. Tsirkin
On Thu, May 14, 2015 at 06:38:24AM +0200, Stefan Weil wrote: > Am 13.05.2015 um 20:15 schrieb Stefano Stabellini: > >On Wed, 13 May 2015, Daniel P. Berrange wrote: > >>On Wed, May 13, 2015 at 06:29:46PM +0100, Stefano Stabellini wrote: > >>>Do not emulate a floppy drive if no drives are supposed to

Re: [Xen-devel] [Qemu-devel] [PATCH] Do not emulate a floppy drive when -nodefaults

2015-05-13 Thread Stefan Weil
Am 13.05.2015 um 20:15 schrieb Stefano Stabellini: On Wed, 13 May 2015, Daniel P. Berrange wrote: On Wed, May 13, 2015 at 06:29:46PM +0100, Stefano Stabellini wrote: Do not emulate a floppy drive if no drives are supposed to be present. This fixes the behavior of -nodefaults, that should remov

Re: [Xen-devel] [Qemu-devel] [PATCH] Do not emulate a floppy drive when -nodefaults

2015-05-13 Thread John Snow
On 05/13/2015 02:15 PM, Stefano Stabellini wrote: > On Wed, 13 May 2015, Daniel P. Berrange wrote: >> On Wed, May 13, 2015 at 06:29:46PM +0100, Stefano Stabellini wrote: >>> Do not emulate a floppy drive if no drives are supposed to be present. >>> >>> This fixes the behavior of -nodefaults, that

Re: [Xen-devel] [Qemu-devel] [PATCH] Do not emulate a floppy drive when -nodefaults

2015-05-13 Thread Stefano Stabellini
On Wed, 13 May 2015, Daniel P. Berrange wrote: > On Wed, May 13, 2015 at 06:29:46PM +0100, Stefano Stabellini wrote: > > Do not emulate a floppy drive if no drives are supposed to be present. > > > > This fixes the behavior of -nodefaults, that should remove the floppy > > drive (see docs/qdev-dev

Re: [Xen-devel] [Qemu-devel] [PATCH] Do not emulate a floppy drive when -nodefaults

2015-05-13 Thread Daniel P. Berrange
On Wed, May 13, 2015 at 06:29:46PM +0100, Stefano Stabellini wrote: > Do not emulate a floppy drive if no drives are supposed to be present. > > This fixes the behavior of -nodefaults, that should remove the floppy > drive (see docs/qdev-device-use.txt:Default Devices), but actually > doesn't. Te